Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve date picker accessibility #12676

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jul 6, 2017

This fixes #12634 and #12673 to improve the date picker accessibility in the following points:

  • Add proper aria-labels to next/previous/close buttons
  • Remove a redundant gridcell role

@timroes timroes added Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Jul 6, 2017
@timroes timroes self-assigned this Jul 6, 2017
@timroes timroes requested a review from cjcenizal July 6, 2017 07:36
@cjcenizal cjcenizal requested a review from aphelionz July 6, 2017 15:31
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@timroes timroes merged commit bc8f394 into elastic:master Jul 12, 2017
@timroes timroes deleted the a11y-date-picker branch July 12, 2017 15:31
@timroes timroes added the v6.0.0 label Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0-rc1 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Date picker buttons missing screen reader friendly attributes
4 participants