Toast notifications: ignore undefined options

[pgayvallet]

Summary

Because of the way the notifications service of the useKibana hook from kibana_react uses core's toast API, by passing every properties, even undefined ones instead of excluding them:

kibana/src/plugins/kibana_react/public/notifications/create_notifications.tsx

Lines 16 to 33 in 6dc31d7

	title,
	body,
	color,
	iconType,
	toastLifeTimeMs,
	onClose,
	}) => {
	if (!services.notifications) {
	throw new TypeError('Could not show notification as notifications service is not available.');
	}
	services.notifications!.toasts.add({
	title: toMountPoint(title, { theme$: services.theme?.theme$ }),
	text: toMountPoint(<>{body || null}</>, { theme$: services.theme?.theme$ }),
	color,
	iconType,
	toastLifeTimeMs,
	onClose,
	});

The internal logic of the toast API to add default values for id and toastLifeTimeMs was broken, as

{
  toastLifeTimeMs: 9000,
  ...{ toastLifeTimeMs: undefined },
}

is { toastLifeTimeMs: undefined }

This PR fixes it by removing options having undefined values before performing the spread.

Closes #125582.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: b5901f2
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
core	292.7KB	292.7KB	+32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[afharo]

LGTM

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.1
✅	8.0
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation