Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove duplicated logic in getIsUsingTransactionEvents #126080

Merged
merged 2 commits into from
Feb 22, 2022
Merged

[APM] Remove duplicated logic in getIsUsingTransactionEvents #126080

merged 2 commits into from
Feb 22, 2022

Conversation

dgieselaar
Copy link
Member

Some of the logic in getIsUsingTransactionEvents was also reproduced in getSearchAggregatedTransactions, this removes from the former whatever is handled in the latter.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Feb 21, 2022
@dgieselaar dgieselaar marked this pull request as ready for review February 22, 2022 08:14
@dgieselaar dgieselaar requested a review from a team as a code owner February 22, 2022 08:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar enabled auto-merge (squash) February 22, 2022 08:19
@dgieselaar dgieselaar merged commit 67a38e6 into elastic:main Feb 22, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 126080

Questions ?

Please refer to the Backport tool documentation

@dgieselaar dgieselaar added the backport:skip This commit does not require backporting label Feb 22, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@dgieselaar @lucasfcosta
[APM] Remove duplicated logic in getIsUsingTransactionEvents (elastic…
ffc3351 
…#126080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgieselaar @elasticmachine @kibana-ci @kibanamachine @sorenlouv