-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTR support mocha dry run #125915
FTR support mocha dry run #125915
Conversation
Interesting, this seems more comprehensive than what we added with the |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
merge conflict between base and head |
packages/kbn-test/src/functional_test_runner/functional_test_runner.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one nit
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @pheyos |
💔 All backports failed
How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # yarn.lock
This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # yarn.lock
This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # package.json # packages/kbn-test/src/functional_test_runner/cli.ts # packages/kbn-test/src/functional_test_runner/functional_test_runner.ts # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # package.json # packages/kbn-test/src/functional_test_runner/cli.ts # packages/kbn-test/src/functional_test_runner/functional_test_runner.ts # yarn.lock Co-authored-by: Kibana Machine <[email protected]>
* FTR support mocha dry run (#125915) This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # yarn.lock * Rebuild @kbn/pm * Rebuild @kbn/pm part 2 Co-authored-by: Kibana Machine <[email protected]>
* FTR support mocha dry run (#125915) This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution. (cherry picked from commit b7db60a) # Conflicts: # yarn.lock * Rebuild @kbn/pm * Rebuild @kbn/pm part 2 Co-authored-by: Kibana Machine <[email protected]>
This PR adds support for the mocha CLI flag `--dry-run` in our functional test execution.
Summary
This PR adds support for the mocha CLI flag
--dry-run
in our functional test execution.Details
dry-run
flag has been introduced with mocha 9.0.0, but I took the chance to update to the latest version that I could find"@types/mocha"
for, which is 9.1.0.--dry-run
flag to ourfunctional_test_runner
andfunctional_tests
scripts and made them pass it through to mochasetupMocha
to acceptreporter
andreporterOptions
overrides, used this for dry runs to pass in ajson
reporter with the output filetarget/functional-tests/dryRunOutput.json
Why do we want this
Output file
The json ouiput file contains some overall stats as well as lists of all tests, passing tests, pending (skipped) tests and failed tests (failed tests list is empty in this case since we don't actually run the tests), e.g.
A test entry in these lists gives us details like the title, full title and file name, e.g.