Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Use existing hook for useKibana access in assets view #125809

Merged
merged 2 commits into from
Feb 22, 2022
Merged

[Fleet] Use existing hook for useKibana access in assets view #125809

merged 2 commits into from
Feb 22, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Feb 16, 2022

Summary

Small refactor to use an existing hook which I didnt realise we had, based on @jen-huang's suggestion here

@hop-dev hop-dev added refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 16, 2022
@hop-dev hop-dev requested a review from a team as a code owner February 16, 2022 15:33
@hop-dev hop-dev self-assigned this Feb 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev
Copy link
Contributor Author

hop-dev commented Feb 22, 2022

@elasticmachine merge upstream

@hop-dev hop-dev enabled auto-merge (squash) February 22, 2022 10:51
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 570 569 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 661.1KB 661.1KB -31.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 1484609 into elastic:main Feb 22, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2022
@hop-dev @kibanamachine
use existing hook for useKibana access (elastic#125809)
5651e21 
(cherry picked from commit 1484609)
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@hop-dev hop-dev deleted the tidy-usekibana-usage branch February 22, 2022 12:47
kibanamachine added a commit that referenced this pull request Feb 22, 2022
@kibanamachine @hop-dev
use existing hook for useKibana access (#125809) (#126150)
53b2e60 
(cherry picked from commit 1484609)

Co-authored-by: Mark Hopkin <[email protected]>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@hop-dev @lucasfcosta
use existing hook for useKibana access (elastic#125809)
193410c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@hop-dev hop-dev

Labels
auto-backport Deprecated - use backport:version if exact versions are needed refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hop-dev @elasticmachine @kibana-ci @kibanamachine @kpollich