Upgrade markdown-it dependency (10.0.0 → 12.3.2).
#125526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
release_note:skip
|
@elasticmachine merge upstream |
flash1293
approved these changes
Feb 15, 2022
jportner
reviewed
Feb 15, 2022
yarn.lock
Outdated
Comment on lines
10352
to
10364
| browserslist@^4.14.5, browserslist@^4.19.1: | ||
| version "4.19.1" | ||
| resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-4.19.1.tgz#4ac0435b35ab655896c31d53018b6dd5e9e4c9a3" | ||
| integrity sha512-u2tbbG5PdKRTUoctO3NBD8FQ5HdPh1ZXPHzp1rwaa5jTc+RV9/+RlWiAIKmjRPQF+xbGM9Kklj5bZQFa2s/38A== | ||
| dependencies: | ||
| caniuse-lite "^1.0.30001286" | ||
| electron-to-chromium "^1.4.17" | ||
| escalade "^3.1.1" | ||
| node-releases "^2.0.1" | ||
| picocolors "^1.0.0" | ||
|
|
||
| browserslist@^4.17.5, browserslist@^4.17.6: | ||
| version "4.18.1" |
There was a problem hiding this comment.
Nit: you could collapse these two dependencies into one
yarn.lock
Outdated
Comment on lines
19464
to
19470
| resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.5.0.tgz#9980b97d9e4194611c36530e7dc46a58d7340fc9" | ||
| integrity sha512-Xb7SVYMvygPxbFMpTFQiHh1J7HClEaThguL15N/Gg37Lri/qKyhRGZYzHRyLH8Stq3Aow0LsHO2O2ci86fCrNQ== | ||
|
|
||
| jquery@^3.6.0: | ||
| version "3.6.0" | ||
| resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.6.0.tgz#c72a09f15c1bdce142f49dbf1170bdf8adac2470" | ||
| integrity sha512-JVzAR/AjBvVt2BmYhxRCSYysDsPcssdmTFnzyLEts9qNwmjmu4JTAMYubEfwVOSwpQ1I1sKKFcxhZCI2buerfw== |
There was a problem hiding this comment.
It looks like jquery@^3.6.0 and jquery@^3.5.0 above can be collapsed into a single dependency.
There was a problem hiding this comment.
Someone still uses jquery, oh no 🙈
yarn.lock
Outdated
Comment on lines
22582
to
22590
| dependencies: | ||
| mimic-fn "^2.1.0" | ||
|
|
||
| onetime@^5.1.2: | ||
| version "5.1.2" | ||
| resolved "https://registry.yarnpkg.com/onetime/-/onetime-5.1.2.tgz#d0e96ebb56b07476df1dd9c4806e5237985ca45e" | ||
| integrity sha512-kbpaSSGJTWdAY5KPVeMOKXSrPtr8C8C7wodJbcsd51jRnmD+GZu8Y0VoU6Dm5Z4vWr0Ig/1NKuWRKf7j5aaYSg== | ||
| dependencies: | ||
| mimic-fn "^2.1.0" |
There was a problem hiding this comment.
It looks like onetime@^5.1.2 and onetime@^5.1.0 above can be collapsed into a single dependency.
There was a problem hiding this comment.
Hmm, not sure, it's onetime not twotimes! 🙂
yarn.lock
Outdated
Comment on lines
26769
to
26779
| ajv "^6.12.5" | ||
| ajv-keywords "^3.5.2" | ||
|
|
||
| schema-utils@^3.1.0, schema-utils@^3.1.1: | ||
| version "3.1.1" | ||
| resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-3.1.1.tgz#bc74c4b6b6995c1d88f76a8b77bea7219e0c8281" | ||
| integrity sha512-Y5PQxS4ITlC+EahLuXaY86TXfR7Dc5lw294alXOq86JAHCihAIZfqv8nNCWvaEJvaC51uN9hbLGeV0cFBdH+Fw== | ||
| dependencies: | ||
| "@types/json-schema" "^7.0.8" | ||
| ajv "^6.12.5" | ||
| ajv-keywords "^3.5.2" |
There was a problem hiding this comment.
It looks like schema-utils@^3.1.0, schema-utils@^3.1.1 and schema-utils@^3.0.0 above can be collapsed into a single dependency.
yarn.lock
Outdated
Comment on lines
26457
to
26887
| semver@^7.2.1, semver@^7.3.2, semver@~7.3.2: | ||
| semver@^7.2.1, semver@^7.3.2: | ||
| version "7.3.2" | ||
| resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.2.tgz#604962b052b81ed0786aae84389ffba70ffd3938" | ||
| integrity sha512-OrOb32TeeambH6UrhtShmF7CRDqhL6/5XpPNp2DuRH6+9QLw/orhp72j87v8Qa1ScDkvrrBNpZcDejAirJmfXQ== |
There was a problem hiding this comment.
It looks like semver@^7.2.1, semver@^7.3.2 and semver@^7.3.4, semver@^7.3.5, semver@~7.3.0 below can be collapsed into a single dependency.
yarn.lock
Outdated
Comment on lines
27169
to
27175
| resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d" | ||
| integrity sha1-tf3AjxKH6hF4Yo5BXiUTK3NkbG0= | ||
|
|
||
| signal-exit@^3.0.3: | ||
| version "3.0.7" | ||
| resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.7.tgz#a9a1767f8af84155114eaabd73f99273c8f59ad9" | ||
| integrity sha512-wnD2ZE+l+SPC/uoS0vXeE9L1+0wuaMqKlfz9AMUo38JsyLSBWSFcHR1Rri62LZc12vLr1gb3jl7iwQhgwpAbGQ== |
There was a problem hiding this comment.
It looks like signal-exit@^3.0.3 and signal-exit@^3.0.0, signal-exit@^3.0.2 above can be collapsed into a single dependency.
yarn.lock
Outdated
Comment on lines
27475
to
27484
| buffer-from "^1.0.0" | ||
| source-map "^0.6.0" | ||
|
|
||
| source-map-support@~0.5.20: | ||
| version "0.5.21" | ||
| resolved "https://registry.yarnpkg.com/source-map-support/-/source-map-support-0.5.21.tgz#04fe7c7f9e1ed2d662233c28cb2b35b9f63f6e4f" | ||
| integrity sha512-uBHU3L3czsIyYXKX88fdrGovxdSCoTGDRZ6SYXtSRxLZUzHg5P/66Ht6uoUlHu9EZod+inXhKo3qQgwXUT/y1w== | ||
| dependencies: | ||
| buffer-from "^1.0.0" | ||
| source-map "^0.6.0" |
There was a problem hiding this comment.
It looks like source-map-support@~0.5.20, source-map-support@^0.5.20 above, and source-map-support@^0.5.16, source-map-support@^0.5.19, source-map-support@^0.5.6, source-map-support@~0.5.12, source-map-support@~0.5.19 above that can be collapsed into a single dependency.
yarn.lock
Outdated
Comment on lines
28867
to
28877
| source-map "~0.7.2" | ||
| source-map-support "~0.5.19" | ||
|
|
||
| terser@^5.7.2: | ||
| version "5.10.0" | ||
| resolved "https://registry.yarnpkg.com/terser/-/terser-5.10.0.tgz#b86390809c0389105eb0a0b62397563096ddafcc" | ||
| integrity sha512-AMmF99DMfEDiRJfxfY5jj5wNH/bYO09cniSqhfoyxc8sFoYIgkJy86G04UoZU5VjlpnplVu0K6Tx6E9b5+DlHA== | ||
| dependencies: | ||
| commander "^2.20.0" | ||
| source-map "~0.7.2" | ||
| source-map-support "~0.5.20" |
There was a problem hiding this comment.
It looks like terser@^5.7.2 and terser@^5.3.4, terser@^5.7.1 above can be collapsed into a single dependency.
yarn.lock
Outdated
Comment on lines
31457
to
31463
| triple-beam "^1.3.0" | ||
| winston-transport "^4.4.0" | ||
|
|
||
| winston@^3.5.1: | ||
| winston@^3.4.0, winston@^3.5.1: | ||
| version "3.5.1" | ||
| resolved "https://registry.yarnpkg.com/winston/-/winston-3.5.1.tgz#b25cc899d015836dbf8c583dec8c4c4483a0da2e" | ||
| integrity sha512-tbRtVy+vsSSCLcZq/8nXZaOie/S2tPXPFt4be/Q3vI/WtYwm7rrwidxVw2GRa38FIXcJ1kUM6MOZ9Jmnk3F3UA== |
There was a problem hiding this comment.
It looks like winston@^3.4.0, winston@^3.5.1 and winston@^3.0.0, winston@^3.3.3 above can be collapsed into a single dependency.
|
I pulled down these changes and ran I was wondering if this might break the Edit: I was able to eventually build the API docs using |
vadimkibana
approved these changes
Feb 16, 2022
|
I looked at the markdown-it For Kibana alerting, we have some very simple jest and functional tests for our markdown usage. Basically just to make sure the basic rendering works; so since checks have passed, the basic functionality still seems to work: |
pmuellr
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
LGTM, for Kibana alerting
I can't really comment on the change to packages/kbn-pm/dist/index.js though - I assume there was some kind of change requiring rebuild of the webpack bits, and it got rebuilt with a newer version of webpack, or something.
I added a comment to the PR pointing out the locations Kibana alerting is doing some basic markdown tests already.
|
Do we need to update |
I assume you meant |
tylersmalley
approved these changes
Feb 18, 2022
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
jportner
approved these changes
Feb 21, 2022
azasypkin
added
the
auto-backport
💔 All backports failed
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
jportner
pushed a commit
that referenced
this pull request
Feb 22, 2022
academo
pushed a commit
to academo/kibana
that referenced
this pull request
Feb 22, 2022
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 2, 2022
academo
added a commit
that referenced
this pull request
Mar 3, 2022
* WIP * WIP2 * Use new cases context hooks to open and close the flyout * Update timelines to use new hooks * CLose flyout on create success * Add back sucess toast * Move code to a dedicated component * Add CasesContext to observability * Remove dependency * Small refactor * Use observabilityAppId instead of observabilityFeatureId for buttons * Add CasesContext to timetable * Fix detection engine test cases * Fix broken tests * Fix broken tests * Rename hook * Add test cases for cases context ui * Add test for new hook * Remove state from the provider context * Remove basevalue * apply suggested renaming * Add usecallback * Add reducer types, fix test type, remove redundant check * Accept attachments as a prop for the cases select modal * Expose useCasesAddToExistingCase hook, reducer code and global component * use the new hook to open the select cases modasl * Fix tests and types * Add tests for cases global components * [Fleet] showing agent policy creation error message on UI (#125931) * showing agent policy creation error message on UI * mapping the error instead of showing from the backend Co-authored-by: Kibana Machine <[email protected]> * [ResponseOps] Adds tooltip to time window selector in ES query rule flyout (#125764) * [Lens] Allow detaching from global time range (#125563) * allow detaching from global time range * add test * fix time field recognition * fix tests Co-authored-by: Kibana Machine <[email protected]> * [Fleet] refactor auto upgrade package policies logic (#125909) * refactor upgrade package policies * fixed tests * code cleanup * review improvements * added api test Co-authored-by: Kibana Machine <[email protected]> * skip flaky suite (#126027) * Remove deprecated api (#125524) * [Fleet] Remove deprecated kibana APIs - License * Remove basePath from FleetApp * Replace AsyncPlugin with Plugin * Get fieldFormats from fieldFormats plugin rather than data plugin * Fix ts errors * Attempt fixing wrong type * Move licenseService to FleetStartDeps * Fix types and mocks Co-authored-by: Kibana Machine <[email protected]> * Upgrade `markdown-it` dependency (`10.0.0` → `12.3.2`). (#125526) * skipping failing tests (#126039) * remove unused deprecated code and use field format plugin directly for data view field editor (#126029) * [data views] Improve preview pane (#126013) * fix preview pane * fix preview pane * one less span tag Co-authored-by: Kibana Machine <[email protected]> * [Alerting] Provide services to set context for recovered alerts (#124972) * Rename alert instance to alert and add create fn to alert factory * Rename alert instance to alert and add create fn to alert factory * Fixing types * Fixing types * Adding flag for rule types to opt into setting recovery context * Only showing context in action variable menu if flag set to true * Adding recovery functions to createAlertFactory * Setting recovery in index threshold and fixing types * Fixing lint issues and some refactoring * Cleanup * Functional tests for index threshold rule recovery context * Return array of recovered alerts instead of record * Fixing types * Fixing types * Cleanup * Handling nulls and more tests * Updating developer docs * Making getRecoveryAlerts non-optional * Setting unknown in index threshold recovery value * PR feedback * Adding a test Co-authored-by: Kibana Machine <[email protected]> * [Discover] Re-introduce saved_searches test (#126059) * [Archive Migration] index pattern without timefield (#125870) * kbn_archive date_nanos * kbn_archive date_nanos in context and discover * kbn_archiver more date_nanos tests * split out kbnArchiver for index_pattern_without_timefield * remove date_nanos files from a different PR * update another test for usage of the same archives * set default index pattern for test * remove duplicate const kibanaServer Co-authored-by: Kibana Machine <[email protected]> * delete unused es_archive visualize_embedding (#126001) * delete unused es_archive * remove other unused es_archive * more unused es_archives Co-authored-by: Kibana Machine <[email protected]> * Bump packages (#126119) * url-parse 1.5.3 -> 1.5.9 * follow-redirects 1.y.z -> 1.14.9 * Add tests for all cases selector and attachments * Add tests for use add to existing case hook * First version of the cases timeline actions * export add alert to new case button from cases plugin * Make Cases ECS compatible with timelines and security_solution * Delete new case button * Add helpers * Use the cases hook directly for add to new case * Remov unused dependencies * Rename callbacks, remove timelines calls * Fixing tests for the dropdown * Fix broken test * mocking cases for tests * Fix detectiosn tests * Observability now uses the new cases hooks * Wrap events viewer into cases context * Open the create case flyout if create case was selected in the modal * Fix cases mocks for security_solution * Update tests * Add tests for use cases toast * Improve cases mock * delete security mock * replace tests mocks for cases * fix import mock * Do not require onRowClick * Show the toast inside the modal * show the toast inside the flyout * remove toast logic from the consumer plugin * fix typescript types * Rename type * Fix broken test * Fix file name and broken test * Use internal navigation hook * Update hook dependencies * Move useCaseToast * Fix mock paths * fix eslint * Add test cases for the toast content * Add cases context to the overview page Co-authored-by: Julia Bardi <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Cristina Amico <[email protected]> Co-authored-by: Aleh Zasypkin <[email protected]> Co-authored-by: Gloria Hornero <[email protected]> Co-authored-by: Matthew Kime <[email protected]> Co-authored-by: Ying Mao <[email protected]> Co-authored-by: Maja Grubic <[email protected]> Co-authored-by: Lee Drengenberg <[email protected]> Co-authored-by: Joe Portner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
markdown-itdependency (10.0.0→12.3.2).Change log: https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md
Note for reviewers: I haven't noticed any significant breaking changes, but would appreciate another pair of eyes on the code you own (
kibana_react/public/markdown/markdown.tsx,vis_types/vislib/public/vislib/lib/handler.js,vis_types/vega/public/vega_view/vega_map_view/service_settings/service_settings.ts, andactions/server/builtin_action_types/lib/send_email.ts).