-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetricVis] Add possibility to configure label font and position in metric unified renderer #125251
[MetricVis] Add possibility to configure label font and position in metric unified renderer #125251
Conversation
@elasticmachine merge upstream |
…configure_labels_params_metric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code mostly LGTM 👍
Only a couple of issues should be addressed.
@VladLasitsa, thanks for your efforts.
src/plugins/chart_expressions/expression_metric/common/types/expression_renderers.ts
Outdated
Show resolved
Hide resolved
src/plugins/chart_expressions/expression_metric/common/types/expression_functions.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍 Thanks, @VladLasitsa, good job 😃
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and this looks pretty good to me, LGTM
Side note: To be able to use it for Visualize / Lens, the unified renderer needs to be able to pick up formatting from the table, seems like this is not the case yet:
kibana | kibana_context savedSearchId=null timeRange={timerange from="now-7d" to="now"} | esaggs index={indexPatternLoad id="90943e30-9a47-11e8-b64d-95841ca0b247"} aggs={aggTerms id="0" enabled=true schema="segment" field="extension.keyword" orderBy="1" order="desc" size=5 otherBucket=true otherBucketLabel="Other" missingBucket=false missingBucketLabel="(missing value)"} aggs={aggAvg id="1" enabled=true schema="metric" field="bytes"} metricsAtAllLevels=false partialRows=false |
metricVis metric={visdimension accessor="col-1-1"} bucket={visdimension accessor="col-0-0"} showLabels=true labelPosition="top" labelFont={font size=24 align="left"}
| render
Part of: #123797
Summary
labelFont
andLabelPosition
args in metric expression.My.Canvas.Workpad.-.Kibana.1.mp4