Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Docs] Add clarity to reporting concepts #125175

Merged
merged 12 commits into from
Feb 11, 2022

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Feb 10, 2022

  1. Closes [Reporting] Document that disabling Reporting completely isn't recommended #120996
  2. Closes Clarify Kibana documentation regarding App privileges and reporting configuration #124839
  3. Closes [Reporting] Document xpack.reporting.kibanaServer as optional #124862

Screenshots

1. Clarifies how to use Kibana Application privileges with Reporting:

image

2. Discourages setting xpack.reporting.enabled: false:

image

3. Clarifies that xpack.reporting.kibanaServer is optional and to handle it with caution, and moves that documentation to the bottom of the page

image

@tsullivan tsullivan changed the title Reporting/docs all [Reporting] Update documentation to clarify various misunderstood concepts Feb 10, 2022
@tsullivan tsullivan changed the title [Reporting] Update documentation to clarify various misunderstood concepts [Reporting/Docs] Add clarity to reporting concepts Feb 10, 2022
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as ready for review February 10, 2022 20:05
@tsullivan tsullivan requested review from a team as code owners February 10, 2022 20:05
@tsullivan tsullivan added v7.17.1 v8.0.0 v8.1.0 v8.2.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of minor edits, but otherwise, LGTM!

docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
Set to `true` (default) to enable the {kib} instance to poll Elasticsearch for pending jobs and claim them for
execution. Setting this to `false` allows the {kib} instance to only add new jobs to the reporting queue, list
jobs, and provide the downloads to completed reports through the UI. This requires a deployment where at least
one other Kibana instance in the Elastic cluster has this setting to `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
one other Kibana instance in the Elastic cluster has this setting to `true`.
one other {kib} instance in the Elastic cluster has this setting set to `true`.

docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 11, 2022
@tsullivan tsullivan merged commit 1095208 into elastic:main Feb 11, 2022
@tsullivan tsullivan deleted the reporting/docs-all branch February 11, 2022 16:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0 Backport failed because of merge conflicts
8.1
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Remove CentOS (#121128)

How to fix

Re-run the backport manually:

node scripts/backport --pr 125175

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)

Co-authored-by: Tim Sullivan <[email protected]>
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 11, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 11, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)

# Conflicts:
#	docs/settings/reporting-settings.asciidoc
tsullivan added a commit that referenced this pull request Feb 11, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)
tsullivan added a commit that referenced this pull request Feb 15, 2022
* discourage setting enabled:false

* mark xpack.reporting.kibanaServer as experimental

* move kibanaServer section down

* add kibana privileges with reporting options screenshot

* rephrase why reporting.roles is depreccated

* screenshot for how to define a custom role the grants reporting privileges

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 1095208)

# Conflicts:
#	docs/settings/reporting-settings.asciidoc

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.17.1 v8.0.0 v8.1.0 v8.2.0
Projects
None yet
6 participants