-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Add warning when remote clusters are configured #125138
[Upgrade Assistant] Add warning when remote clusters are configured #125138
Conversation
@@ -0,0 +1,44 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed pattern used in #109543
getRemoteClustersDetectedDescription: (remoteClustersCount: number) => | ||
i18n.translate('xpack.upgradeAssistant.esDeprecations.remoteClustersDetectedDescription', { | ||
defaultMessage: | ||
'You have {remoteClustersCount} {remoteClustersCount, plural, one {remote cluster} other {remote clusters}} configured. If you use cross-cluster search, note that 8.x can only search remote clusters 7.17 or later. If you use cross-cluster replication, a cluster that contains follower indices must run the same or newer version as the remote cluster.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrodewig do you have bandwidth to review this text?
@elasticmachine merge upstream |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
/cc @LeeDr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding this warning, @alisonelizabeth!
Tested locally and all worked as expected, code changes LGTM too 👍
.../plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Outdated
Show resolved
Hide resolved
…/es_deprecations/es_deprecations.tsx Co-authored-by: James Rodewig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version. This means a local 8.1 cluster can only search remote 8.0+ clusters. Relates to elastic/kibana#125138 and #1970
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version. This means a local 8.1 cluster can only search remote 8.0+ clusters. Relates to elastic/kibana#125138 and #1970 (cherry picked from commit 70964c7)
Updates the upgrade guide to clarify BWC for CCS. Based on [the CCS docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cross-cluster-search.html#ccs-supported-configurations), you can only search back one minor version. This means a local 8.1 cluster can only search remote 8.0+ clusters. Relates to elastic/kibana#125138 and #1970 (cherry picked from commit 70964c7)
Summary
Fixes #124465
This PR adds a warning to the ES deprecations page if we detect the user has any remote clusters configured. It also adds a locator to the
remote_clusters
plugin, so that we can easily link to Remote Clusters from UA.How to test