Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APM execution context - app, page, entitiy id #124996
APM execution context - app, page, entitiy id #124996
Changes from 42 commits
7deba6b
c44c4f2
6b18395
a0044cd
1115e93
ac41e1f
c2ed495
600607c
85408b1
efb7952
5da627a
1c1fce1
ed018ba
5200052
4c151dd
b64e5e2
f1fc110
f413c38
97350de
cf33228
666441c
d8c69c4
6168b00
abcccdc
824cb2a
89d7064
e32f869
a0c344e
756e7f5
aa6b774
7cce534
ccb285d
8efe9ad
7402fba
21e4438
c9fa18d
4b29f04
b600cc0
7cfd118
400731a
2a1a373
2b45d23
1cedb99
bb58dd2
2f2be65
349ef2c
47447e1
46807d3
efd5ea4
80b1b68
3c8a87d
86b8cba
66d6d3c
7c500c7
358515d
cb939d1
1dce721
84129cb
984abf3
77decb1
2c0efd2
19140f7
8a420c5
5dad2dc
4facdf1
585d690
f094803
59960cf
2a15a64
b0e216d
c10afe8
d7c01e4
4a96dac
a78a4b8
4dbc83e
4c83f61
a57bed7
7d8b955
373eb31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to enforce that
set
is called only once per app? As mentioned below (see https://github.com/elastic/kibana/pull/124996/files#r802797191), we have different logic on the server-side.It's always hard to think about the final shape of an object after several mutations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Server-side doesn't merge the contexts but gets the final version. It allows customers to implement any custom logic.