Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Missing vega vis is when generating report from sample data #124886

Merged
merged 3 commits into from
Feb 18, 2022
Merged

[Reporting] Missing vega vis is when generating report from sample data #124886

merged 3 commits into from
Feb 18, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 7, 2022 •
edited
Loading

Closes: #124556

Summary

Describe the bug:

When generating a PDF preserve-layout report from the packaged dashboard of the Web traffic logs sample data, a vega vis is missing.

Steps to reproduce:

  1. Start Kibana
  2. Install sample data for the web traffic logs
  3. Go to dashboard and generate a report (not print-optimized)

Expected behavior:
The visualistation should be present

Renderers count:
image

Downloaded reports

[Logs] Web Traffic.pdf
report_3
report_2.pdf
report_1.pdf

@alexwizp alexwizp self-assigned this Feb 7, 2022
@alexwizp alexwizp added v8.2.0 Feature:Vega Vega visualizations labels Feb 7, 2022
@alexwizp alexwizp added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:fix labels Feb 7, 2022
@alexwizp alexwizp added the backport:skip This commit does not require backporting label Feb 8, 2022
@alexwizp alexwizp marked this pull request as ready for review February 8, 2022 08:23
@alexwizp alexwizp requested a review from a team as a code owner February 8, 2022 08:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra mbondyra changed the title [Reporting] Missing vis when generating report from sample data [Reporting] Missing vega vis is when generating report from sample data Feb 8, 2022
@alexwizp alexwizp added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Feb 8, 2022
flash1293
flash1293 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and it renders fine for me. @jloleysens could you have a look as well?

@alexwizp
Copy link
Contributor Author

@dziyanadzeraviankina thank you 🥇 , temporary moved to Draft to check your case.

@alexwizp alexwizp marked this pull request as draft February 10, 2022 11:59
DianaDerevyankina
DianaDerevyankina approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally, works fine 👍

@alexwizp alexwizp marked this pull request as ready for review February 11, 2022 09:42
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp requested a review from a team as a code owner February 16, 2022 13:11
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elastic/stack-design Please have a look

@flash1293
Copy link
Contributor

The report part seems to work fine for me. However, the scrollbar issue isn't fixed by this change, it probably makes sense to split it out to get the reporting fix into 8.1 ASAP:
Kapture 2022-02-17 at 18 20 00

@alexwizp alexwizp removed the request for review from a team February 18, 2022 10:05
@alexwizp alexwizp enabled auto-merge (squash) February 18, 2022 10:06
@alexwizp alexwizp merged commit 88354aa into elastic:main Feb 18, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 2.0MB 2.0MB +605.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
visTypeVega 7 6 -1

Total ESLint disabled count

id before after diff
visTypeVega 7 6 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@kibanamachine kibanamachine mentioned this pull request Feb 18, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2022
@alexwizp @kibanamachine
[Reporting] Missing vega vis is when generating report from sample da…
f53f7e8 
…ta (elastic#124886)

* [Reporting] Missing vega vis is when generating report from sample data

Closes: elastic#124886

* Update vega_vis.scss

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 88354aa)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 18, 2022
@kibanamachine @alexwizp
[Reporting] Missing vega vis is when generating report from sample da…
ed5ab12 
…ta (#124886) (#126017)

* [Reporting] Missing vega vis is when generating report from sample data

Closes: #124886

* Update vega_vis.scss

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 88354aa)

Co-authored-by: Alexey Antonov <[email protected]>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@alexwizp @kibanamachine @lucasfcosta
[Reporting] Missing vega vis is when generating report from sample da…
cfce4c1 
…ta (elastic#124886)

* [Reporting] Missing vega vis is when generating report from sample data

Closes: elastic#124886

* Update vega_vis.scss

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@DianaDerevyankina DianaDerevyankina DianaDerevyankina approved these changes

@jloleysens jloleysens Awaiting requested review from jloleysens

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Vega Vega visualizations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Missing vis when generating report from sample data
6 participants
@alexwizp @elasticmachine @flash1293 @kibana-ci @kibanamachine @DianaDerevyankina