Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Lucene query on dashboard level is not respected for annotations and table tab #124802

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 7, 2022

Closes: #124693

Summary

Describe the bug: If "ignore global filters" is disabled on an annotations source, the global filters are ignored nevertheless in case the query is specified as lucene

Steps to reproduce:

  1. Configure TSVB visualization with annotations source and disabled "ignore global filters"
  2. Add to dashboard
  3. Filter dashboard using KQL, observe annotations being filtered as expected
  4. Filter dashboard using Lucene, observe annotations not being filtered anymore

The same issue valid for Table tab.

Screens:

Annotations:
image

Table:
image

@alexwizp alexwizp changed the title [TSVB] Lucene query on dashboard level is not respected for annotations [TSVB] Lucene query on dashboard level is not respected for annotations and table tab Feb 7, 2022
@alexwizp alexwizp requested a review from flash1293 February 7, 2022 12:38
@alexwizp alexwizp added v8.1.0 v8.2.0 Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed v8.1.0 labels Feb 7, 2022
@alexwizp alexwizp requested a review from stratoula February 7, 2022 12:57
@alexwizp alexwizp marked this pull request as ready for review February 7, 2022 14:18
@alexwizp alexwizp requested a review from a team as a code owner February 7, 2022 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293 flash1293 added auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 and removed backport:skip This commit does not require backporting labels Feb 8, 2022
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@alexwizp
Copy link
Contributor Author

alexwizp commented Feb 8, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 815685f into elastic:main Feb 8, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
…ns request (elastic#124802)

Closes: elastic#124693

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 815685f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 8, 2022
…ns request (#124802) (#124955)

Closes: #124693

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 815685f)

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TSVB] Lucene query on dashboard level is not respected for annotations request
5 participants