Alert doesn't fire action if it's muted or throttled #124775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
approved these changes
Feb 7, 2022
ersin-erdal
added
backport
v8.1.0
auto-backport
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 10, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.ts
ersin-erdal
added a commit
that referenced
this pull request
Feb 10, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.ts Co-authored-by: Kibana Machine <[email protected]>
|
The SDH that referenced this issue ^^^ asked about a backport to 7.last. I assume that's reasonable, maybe some additional type name changes? :-) |
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 11, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.test.ts # x-pack/plugins/alerting/server/task_runner/task_runner.ts
ersin-erdal
added a commit
that referenced
this pull request
Feb 11, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.test.ts # x-pack/plugins/alerting/server/task_runner/task_runner.ts Co-authored-by: Kibana Machine <[email protected]>
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 14, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.test.ts # x-pack/plugins/alerting/server/task_runner/task_runner.ts
|
Manually backported to |
ersin-erdal
added a commit
that referenced
this pull request
Feb 14, 2022
* Alert doesn't fire action if it's muted or throttled (cherry picked from commit e4dd6e7) # Conflicts: # x-pack/plugins/alerting/server/task_runner/task_runner.test.ts # x-pack/plugins/alerting/server/task_runner/task_runner.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #124170
Task Runner was still firing actions for muted or throttled alerts if notifyWhen === 'onActionGroupChange'.
With this fix, no action will be fired if an alert is muted, throttled or notifyWhen === 'onActionGroupChange' and scheduled action group/subgroup hasn't changed.