Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Discover locator to generate URL #124282

Merged
merged 7 commits into from
Feb 15, 2022
Merged

Use Discover locator to generate URL #124282

merged 7 commits into from
Feb 15, 2022

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Feb 1, 2022 •
edited
Loading

Summary

Switches to Discover locator instead of deprecated URL generator.

For maintainers

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana vadimkibana added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 14, 2022
@vadimkibana vadimkibana marked this pull request as ready for review February 14, 2022 22:16
@vadimkibana vadimkibana requested a review from a team as a code owner February 14, 2022 22:16
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #21 / apps transform basic license transform permissions for user with full transform access with data loaded should display controls in the edit flyout correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 452.4KB 452.4KB -63.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana changed the title use Discover locator to generate URL Use Discover locator to generate URL Feb 15, 2022
@cjcenizal cjcenizal assigned cjcenizal and unassigned cjcenizal Feb 15, 2022
yuliacech
yuliacech approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating Ingest pipelines to use the new locator, @vadimkibana!
code changes LGTM, also tested locally and the link to Discover works as expected.

@vadimkibana vadimkibana merged commit ea059d4 into elastic:main Feb 15, 2022
@vadimkibana vadimkibana added the backport:skip This commit does not require backporting label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vadimkibana @kibana-ci @yuliacech @cjcenizal @kibanamachine