Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add metric Viz config options, title position and sizing #124124
[Lens] Add metric Viz config options, title position and sizing #124124
Changes from 1 commit
dbdc290
b093f5e
ba3448e
932545d
b3329c2
e1b2643
c1934ed
b0aaec6
00328a7
da64340
5ebd718
9384fa1
a0514f8
b9f7a61
3bfdf0b
159ffd0
05c8b50
56c0bb4
71c3162
321f8f3
b139f93
e4d3b03
cd89b4e
8726fb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts on the namings here.
title
is usually referred to the title of the chart (the one that appears on the dashboard on the top/left corner of the embeddable).In this case, this is a label on the visualization. In the Lens editor is called
Display name
so I think we should align the two namings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the terms used for these text-based elements in Lens are contextual depending on the current visualization and where the text is used. For example, we use all of the following in difference circumstances:
Dashboards does use the term "panel title" for top-left text in a dashboard panel. While there could be some potential for confusion between Lens' usage of "title" and Dashboard's usage of "panel title", I don't think it's a huge concern at the moment for the following reasons:
For the time being, I'm personally fine with the term "title" in this circumstance, but I will defer to others if they feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelMarcialis I'm a bit confused because I don't see where in Lens you are using the words
title
andsubtitle
in the single metric visualizations.I see a
Display name
field that I can change to change the metric name, but I don't see any title or subtitle in any of our options. The only place I see thetitle
word is in the CSS class name.In the other metric vis (aggregated) I can see a
Custom label
that can be used to change the metric name.This is actually badly aligned with the option to show and hide that name called
Show title
The title is used on the
Axis
instead, where you can configure theAxis title
in the top menu that changes theDisplay name
of the vertical or horizontal axis.When I think of a
title
, to me always refers to something more descriptive like:Memory consumption in the last week
and is more suitable to be places on the top-left part of the visualization (aka panel title). Alabel
instead, is used in various places and contains usually less information, just a tag:RAM
,CPU %
, really similar to whatname
is about.As always is a matter of consistency across the interface and I don't see that neither with the term
title
or thelabel
.cc @gvnmagni