Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add metric Viz config options, title position and sizing #124124
[Lens] Add metric Viz config options, title position and sizing #124124
Changes from 8 commits
dbdc290
b093f5e
ba3448e
932545d
b3329c2
e1b2643
c1934ed
b0aaec6
00328a7
da64340
5ebd718
9384fa1
a0514f8
b9f7a61
3bfdf0b
159ffd0
05c8b50
56c0bb4
71c3162
321f8f3
b139f93
e4d3b03
cd89b4e
8726fb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the default size isn't handled on the
toExpression
level like position and alignment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed default here because we use default font size in class
lnsMetricExpression__value
and don't needed to add this class if size is not defained.