Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Backend to Dependency #124067

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Jan 29, 2022

Summary

Rename Backend to Dependency which was missed in #110523 (see #123792)

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@tobiasstadler tobiasstadler requested a review from a team as a code owner January 29, 2022 08:22
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jan 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop
Copy link
Contributor

@tobiasstadler thanks for changing this!

@gbamparop
Copy link
Contributor

Buildkite, test this

@gbamparop
Copy link
Contributor

retest

@tobiasstadler
Copy link
Contributor Author

@elasticmachine merge upstream

@tobiasstadler
Copy link
Contributor Author

@gbamparop Would you please run the tests again?

@gbamparop
Copy link
Contributor

retest

@gbamparop
Copy link
Contributor

Buildkite, test this

@gbamparop
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@tobiasstadler
Copy link
Contributor Author

@elasticmachine merge upstream

@tobiasstadler
Copy link
Contributor Author

@gbamparop Could you please merge this PR?

@formgeist
Copy link
Contributor

@gbamparop I'd argue for a backport to 8.1 as well since this is a copy bug in the UI which would be nice to just update.

Thanks @tobiasstadler for submitting a PR for this 👍

@gbamparop
Copy link
Contributor

Buildkite, test this

@gbamparop
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed v8.2.0 labels Feb 8, 2022
@gbamparop gbamparop merged commit 73cc08e into elastic:main Feb 8, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 8, 2022
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.2.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
* Rename Backend to Dependency which was missed in elastic#110523

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 73cc08e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Feb 8, 2022
* Rename Backend to Dependency which was missed in elastic#110523

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 73cc08e)
@tobiasstadler tobiasstadler deleted the rename-backand-to-dependency branch February 8, 2022 18:18
@tobiasstadler
Copy link
Contributor Author

Thank You!

kibanamachine added a commit that referenced this pull request Feb 8, 2022
* Rename Backend to Dependency which was missed in #110523

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 73cc08e)

Co-authored-by: Tobias Stadler <[email protected]>
@gbamparop gbamparop added apm:test-plan-done Pull request that was successfully tested during the test plan apm:test-plan-8.1.0 and removed apm:test-plan-done Pull request that was successfully tested during the test plan labels Feb 9, 2022
@gbamparop gbamparop self-assigned this Feb 9, 2022
@gbamparop
Copy link
Contributor

Thank You!

Thanks for the work :)

@gbamparop gbamparop added the apm:test-plan-done Pull request that was successfully tested during the test plan label Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting 💝community release_note:fix Team:APM All issues that need APM UI Team support v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants