Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Visualize][Canvas] Adds titles to the heatmap axis #123992

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 28, 2022

Summary

Part of #102036
This PR:

  • adds titles on the heatmap axis
  • moves lens heatmap out of the experimental status
  • adds axis title settings on lens heatmap (they should work as the xy titles)
  • adds canvas title visibility toggles

Lens
image

Visualize Heatmap
image

This is the last thing that was needed to move Lens heatmap out of experimental status.

Canvas Heatmap
image

Checklist

Sorry, something went wrong.

@stratoula stratoula added release_note:enhancement Feature:Heatmap Heatmap visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.1.0 labels Jan 28, 2022
@stratoula stratoula requested a review from a team as a code owner January 28, 2022 07:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula changed the title [Lens - Viz editor] Adds titles to the heatmap axis, lens heatmap out of experimental [Lens - Viz editor] Adds titles to the heatmap axis Jan 28, 2022
@stratoula stratoula changed the title [Lens - Viz editor] Adds titles to the heatmap axis [Lens][Visualize] Adds titles to the heatmap axis Jan 28, 2022
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@dej611
Copy link
Contributor

dej611 commented Jan 31, 2022

It would be great to add also some axis controls as for XY charts, also to make charts render as before for those who prefer them without axis titles:
Screenshot 2022-01-31 at 10 55 54

@stratoula stratoula requested a review from a team as a code owner January 31, 2022 15:11
@stratoula stratoula changed the title [Lens][Visualize] Adds titles to the heatmap axis [Lens][Visualize][Canvas] Adds titles to the heatmap axis Jan 31, 2022
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@stratoula stratoula added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 31, 2022
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, only a label thing to address.
Tested locally and it works 👍 , will approve to unblock once the label thing gets fixed.

@stratoula
Copy link
Contributor Author

stratoula commented Jan 31, 2022

@dej611 this is how it is now on xy axis. The screenshot is from 7.16, I didn't change anything here, I just moved the code to a separate file. :D
image

Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes LGTM 👍

@stratoula
Copy link
Contributor Author

@dej611 I finally decided to do the change here :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 735 736 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionHeatmap 95 109 +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +970.0B
expressionHeatmap 15.0KB 15.3KB +277.0B
lens 1.0MB 1.0MB +2.7KB
total +3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionHeatmap 12.2KB 13.0KB +730.0B
visTypeHeatmap 10.3KB 10.4KB +46.0B
total +776.0B
Unknown metric groups

API count

id before after diff
expressionHeatmap 99 113 +14

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 913eac0 into elastic:main Feb 1, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas Feature:Heatmap Heatmap visualization Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants