-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens][Visualize][Canvas] Adds titles to the heatmap axis #123992
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
x-pack/plugins/lens/public/shared_components/axis_title_settings.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, only a label thing to address.
Tested locally and it works 👍 , will approve to unblock once the label thing gets fixed.
@dej611 this is how it is now on xy axis. The screenshot is from 7.16, I didn't change anything here, I just moved the code to a separate file. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canvas changes LGTM 👍
@dej611 I finally decided to do the change here :) |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Part of #102036
This PR:
Lens
Visualize Heatmap
This is the last thing that was needed to move Lens heatmap out of experimental status.
Canvas Heatmap
Checklist