Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to configure grid for TSVB #12385

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Adding ability to configure grid for TSVB #12385

merged 1 commit into from
Jul 10, 2017

Conversation

simianhacker
Copy link
Member

This PR allows the user to configure if the grid should be displayed or not

image

CC @tbragin @alexfrancoeur

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.6.0 v6.0.0 v6.0.0-alpha3 labels Jun 16, 2017
ppisljar
ppisljar approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 7, 2017 •
edited
Loading

is the backport to 5.6 necessary? I believe we're only doing bug fixes there, so I removed the label. I may be wrong, so I'd double check with @epixa.

discussed with @tbragin, ok for 5.6

@simianhacker simianhacker merged commit 0ec883d into elastic:master Jul 10, 2017
simianhacker added a commit that referenced this pull request Jul 10, 2017
@simianhacker
Adding ability to configure grid for TSVB (#12385)
3dac10a
@simianhacker
Copy link
Member Author

Back ported to 5.x with 3dac10a

@simianhacker simianhacker deleted the tsvb-grids branch April 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement review v5.6.0 v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simianhacker @thomasneirynck @ppisljar @epixa @jimgoodwin