Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][Home] Rename IndexPattern to DataView #123593

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Jan 24, 2022

Summary

Based on this comment we need to properly rename the prop in the Home app so it doesn't look like we apply different logics across the platform when validating if there's any User data.

For maintainers

@afharo afharo added chore Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Jan 24, 2022
@afharo afharo requested a review from a team as a code owner January 24, 2022 12:57
@afharo afharo requested a review from ryankeairns January 24, 2022 12:57
@afharo afharo enabled auto-merge (squash) January 24, 2022 13:17
@afharo afharo merged commit dcae24a into elastic:main Jan 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 77.4KB 77.4KB -8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo deleted the chore/home/rename-indexPattern-to-DataView branch January 24, 2022 14:16
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants