Add enable_fields_emulation flag to search requests #123267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
9 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…arch-fields-emulation
ppisljar
reviewed
Jan 25, 2022
| @@ -32,6 +32,7 @@ export async function getIgnoreThrottled( | |||
| export async function getDefaultAsyncSubmitParams( | |||
| uiSettingsClient: Pick<IUiSettingsClient, 'get'>, | |||
| searchSessionsConfig: SearchSessionsConfigSchema | null, | |||
| params: any, | |||
ppisljar
reviewed
Jan 25, 2022
ppisljar
reviewed
Jan 25, 2022
| @@ -44,7 +45,9 @@ export async function getDefaultAsyncSubmitParams( | |||
| | 'ignore_unavailable' | |||
| | 'track_total_hits' | |||
| | 'keep_on_completion' | |||
| > | |||
| > & { | |||
| enable_fields_emulation: boolean; | |||
There was a problem hiding this comment.
shouldn't we do the same for es search strategy ?
what about rollups ?
There was a problem hiding this comment.
I've updated the PR to support our default search strategy which is used by other strategies
nreese
approved these changes
Jan 25, 2022
4 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
banderror
added a commit
that referenced
this pull request
Feb 10, 2022
**Fixes:** #125059 ## Summary Fixes a bug in the EQL search strategy presumably introduced in #123267. ## Screenshots **Before** (request to EQL search strategy is failing, and the rule creation form can't perform validation)  **After** (request to EQL search strategy is returning results, and the rule creation form can properly validate the query)    ## Notes on testing Create a test index and write a few documents to it: ``` PUT /test-eql { "mappings": { "properties": { "@timestamp": { "type": "date" }, "process": { "type": "object", "properties": { "name": { "type": "keyword" } } } } } } POST /test-eql/_doc { "@timestamp": "2022-02-05T10:00:08Z", "process": { "name": "mdworker" } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: elastic/elasticsearch#82539, elastic/elasticsearch#82485
Replaces #123010.
Adds the
enable_fields_emulationflag to search requests so that fields show up in scenarios where CCS is in use with a cluster that doesn't support the newfieldsoption in ES.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers
Release note
Fixes cross-cluster-search when using the
fieldssearch request parameter for versions of Elasticsearch prior to 7.0.