Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Update CSV Export tests #123093

Merged
merged 5 commits into from
Jan 14, 2022
Merged

[Reporting] Update CSV Export tests #123093

merged 5 commits into from
Jan 14, 2022

Conversation

tsullivan
Copy link
Member

Summary

Closes #123082

TinaHeiligers
TinaHeiligers approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@TinaHeiligers
Copy link
Contributor

still LGTM

@tsullivan tsullivan merged commit b756a53 into elastic:no-include_type_name Jan 14, 2022
@tsullivan tsullivan deleted the no-include_type_name-csv1 branch January 14, 2022 22:51
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 14, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #25 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] Default CI Group #25 / discover Discover CSV Export Generate CSV: new search generates a report from a new search with data: default
  • [job] [logs] Default CI Group #1 / Observability specs (trial) Observability annotations when creating an annotation completes with a 200 and the created annotation if data is complete and valid
  • [job] [logs] Default CI Group #1 / Observability specs (trial) Observability annotations when creating an annotation completes with a 200 and the created annotation if data is complete and valid
  • [job] [logs] Default CI Group #2 / Reporting APIs CSV Generation from SearchSource Exports CSV with almost all fields when using fieldsFromSource
  • [job] [logs] Default CI Group #2 / Reporting APIs CSV Generation from SearchSource Exports CSV with almost all fields when using fieldsFromSource

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [429bfbd]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mshustov pushed a commit to mshustov/kibana that referenced this pull request Jan 15, 2022
Revert "[Reporting] Update CSV Export tests (elastic#123093)"
8e5f470 
This reverts commit b756a53.
@rudolf rudolf mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsullivan @TinaHeiligers @kibana-ci