Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix analyzer full screen with new eui data grid #122986

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Jan 13, 2022

Summary

Until Eui supports elastic/eui#5126 a solution like this is the best way to make the analyzer full screen behavior work with datagrid full screen.

analyzer_full_screen

Checklist

@kqualters-elastic kqualters-elastic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jan 13, 2022
@kqualters-elastic kqualters-elastic changed the title Fix analyzer full screen with new eui data grid [Security Solution] Fix analyzer full screen with new eui data grid Jan 26, 2022
@kqualters-elastic kqualters-elastic marked this pull request as ready for review February 2, 2022 13:46
@kqualters-elastic kqualters-elastic requested review from a team as code owners February 2, 2022 13:46
@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 2, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests / Detection rules, machine learning Creates and activates a new ml rule
  • [job] [logs] Security Solution Tests / Inspect Timeline inspects the timeline

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +362.0B
timelines 226.6KB 226.6KB -13.0B
total +349.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 246.0KB 246.2KB +164.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic
Copy link
Contributor Author

closing in favor of using elastic/eui#5590

@kqualters-elastic kqualters-elastic deleted the analyzer-full-screen-new-eui branch February 3, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants