[Fleet] Fix reset one preconfiguration API #122963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Jan 13, 2022
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @nchaulet |
💔 All backports failed
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jan 13, 2022
(cherry picked from commit cfd7cc3) # Conflicts: # x-pack/plugins/fleet/server/routes/preconfiguration/handler.ts # x-pack/plugins/fleet/server/routes/preconfiguration/index.ts
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jan 13, 2022
(cherry picked from commit cfd7cc3) # Conflicts: # x-pack/plugins/fleet/server/routes/preconfiguration/handler.ts # x-pack/plugins/fleet/server/routes/preconfiguration/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #122467
When doing some test on the reset preconfiguration APIs I discovered that I miss a few things and the reset one preconfigured API was not working as expected (resetting all the preconfigured policies instead of one)
That PR address that and add missing tests that would have catch that.