Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix major mobile issues with security overview #122770

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Conversation

snide
Copy link
Contributor

@snide snide commented Jan 12, 2022

Summary

cc @gavinwye

Fixes #121403

There's lots more to do on this page, but this fixes the major issues and makes everything render. I'll try to follow up with something more involved for the individual components later.

BEFORE

image

AFTER

Checklist

Delete any items that are not applicable to this PR.

Comment on lines +93 to +97
<EuiShowFor sizes={['xl']}>
<EuiFlexItem grow={1}>
<StatefulSidebar />
</EuiFlexItem>
</EuiShowFor>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this column is critical to the page. This removes it from mobile views.

@snide snide added Feature:SecurityOverview Security Solution Overview feature Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 12, 2022
@snide snide marked this pull request as ready for review January 13, 2022 14:53
@snide snide requested a review from a team as a code owner January 13, 2022 14:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@snide
Copy link
Contributor Author

snide commented Jan 13, 2022

@elasticmachine merge upstream

@snide snide added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 13, 2022
@snide
Copy link
Contributor Author

snide commented Jan 18, 2022

@elasticmachine merge upstream

@snide snide requested a review from michaelolo24 January 18, 2022 13:22
@snide
Copy link
Contributor Author

snide commented Jan 18, 2022

Hey @michaelolo24. Mind giving me a quick review? This doesn't fix all of the issues on the page (the accordions are still off, and the graphs might need some work), but it fixes the biggest ones and makes the page readable

Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @snide. I pulled down and tested the changes and they look good! LGTM 🚀
Also, I don't think there was ever a discussion about what doesn't have to be visible in the mobile view, but could be useful for any other views that might be affected.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -548.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@snide
Copy link
Contributor Author

snide commented Jan 18, 2022

Thanks for the view. Well, easy to change if their is feedback. Gonna merge this for 8.1 just to fix the major break. We can iterate over time as we need.

@snide snide merged commit a2c2adf into elastic:main Jan 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 18, 2022
@snide snide deleted the securityoverview branch January 18, 2022 20:13
@snide snide changed the title [DRAFT] Fix major mobile issues with security overview Fix major mobile issues with security overview Jan 18, 2022
@snide snide added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Jan 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 18, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 122770

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting Feature:SecurityOverview Security Solution Overview feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Data is not rendered on mobile viewport < 767 px
5 participants