-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix major mobile issues with security overview #122770
Conversation
<EuiShowFor sizes={['xl']}> | ||
<EuiFlexItem grow={1}> | ||
<StatefulSidebar /> | ||
</EuiFlexItem> | ||
</EuiShowFor> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this column is critical to the page. This removes it from mobile views.
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Hey @michaelolo24. Mind giving me a quick review? This doesn't fix all of the issues on the page (the accordions are still off, and the graphs might need some work), but it fixes the biggest ones and makes the page readable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @snide. I pulled down and tested the changes and they look good! LGTM 🚀
Also, I don't think there was ever a discussion about what doesn't have to be visible in the mobile view, but could be useful for any other views that might be affected.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Thanks for the view. Well, easy to change if their is feedback. Gonna merge this for 8.1 just to fix the major break. We can iterate over time as we need. |
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
Summary
cc @gavinwye
Fixes #121403
There's lots more to do on this page, but this fixes the major issues and makes everything render. I'll try to follow up with something more involved for the individual components later.
responsive={false}
for places whereEuiFlexGroup
is using a column layout to avoid flex-basis. I'm going to attack this separately in [EuiFlexGroup] Whendirection="column"
we should setresponsive={false}
or adjust the styling to ignore responsive css eui#5529BEFORE
AFTER
Checklist
Delete any items that are not applicable to this PR.