Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix context view for document ids containing special characters #122737

Merged
merged 5 commits into from
Jan 14, 2022
Merged

[Discover] Fix context view for document ids containing special characters #122737

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9948c4
[Discover] fix encoded param for context
dimaanj Jan 12, 2022
a7bd66b
[Discover] add functional test
dimaanj Jan 13, 2022
76a7586
[Discover] add test file
dimaanj Jan 13, 2022
2a8fa71
[Discover] change field name
dimaanj Jan 14, 2022
5a7e5a5
Merge branch 'main' into fix-context-encoded-params
kibanamachine Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plugins/discover/public/application/context/context_app_route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function ContextAppRoute(props: DiscoverRouteProps) {
const { chrome } = services;

const { indexPatternId, id } = useParams<ContextUrlParams>();
const anchorId = decodeURIComponent(id);
const breadcrumb = useMainRouteBreadcrumb();

useEffect(() => {
Expand Down Expand Up @@ -68,5 +69,5 @@ export function ContextAppRoute(props: DiscoverRouteProps) {
return <LoadingIndicator />;
}

return <ContextApp anchorId={id} indexPattern={indexPattern} />;
return <ContextApp anchorId={anchorId} indexPattern={indexPattern} />;
}