Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize anomaly explorer tests #122247

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jan 4, 2022

Summary

This PR stabilizes the anomaly explorer tests for adding a swim lane to a dashboard by validating the dashboard table row count after filtering.

Closes #118584

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Jan 4, 2022
@pheyos pheyos self-assigned this Jan 4, 2022
@pheyos pheyos requested a review from a team as a code owner January 4, 2022 12:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jan 4, 2022

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@pheyos pheyos changed the title Stabilize swimlane to dashboard test [ML] Functional tests - stabilize anomaly explorer tests Jan 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +76.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 1a886c2 into elastic:main Jan 5, 2022
@pheyos pheyos deleted the stabilize_swimlane_to_dashboard_test branch January 5, 2022 09:45
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 5, 2022
)

This PR stabilizes the anomaly explorer tests for adding a swim lane to a dashboard by validating the dashboard table row count after filtering.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jan 5, 2022
…122317)

This PR stabilizes the anomaly explorer tests for adding a swim lane to a dashboard by validating the dashboard table row count after filtering.

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.0.0 v8.1.0
Projects
None yet
6 participants