Fix import_saved_objects_between_versions.ts FTR test
#122243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
commented
Jan 4, 2022
Comment on lines
+30
to
+33
| const count = Number.parseInt(parts[1], 10); | ||
| if (count === 0) { | ||
| throw new Error('text not loaded yet'); | ||
| } |
There was a problem hiding this comment.
The new failure occurs because before the ajax calls are performed, the label displays exports 0 objects. We're now waiting until the end of the call by checking that the numeric value is not zero (there will always be at least one object in the table, as the config object is present)
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
afharo
approved these changes
Jan 10, 2022
pgayvallet
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2022
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 389a87d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2022
…22553) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 389a87d) Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #121968