Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/utils #121924

Merged
merged 2 commits into from
Dec 23, 2021
Merged

chore(NA): splits types from code on @kbn/utils #121924

merged 2 commits into from
Dec 23, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 22, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 22, 2021
@mistic mistic requested a review from jbudz December 22, 2021 22:29
@mistic mistic requested review from vigneshshanmugam and a team as code owners December 22, 2021 22:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic
Copy link
Member Author

mistic commented Dec 23, 2021

@vigneshshanmugam @elastic/kibana-core we've only changed the package build files here so I'm going ahead and merge this PR. Let me know if you have additional feedback

@mistic mistic merged commit 64468b7 into elastic:main Dec 23, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 23, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@vigneshshanmugam vigneshshanmugam Awaiting requested review from vigneshshanmugam vigneshshanmugam is a code owner

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibana-ci @jbudz @kibanamachine