Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): use internal pkg_npm on @kbn/spec-to-console #121812

Merged
merged 1 commit into from
Dec 22, 2021
Merged

chore(NA): use internal pkg_npm on @kbn/spec-to-console #121812

merged 1 commit into from
Dec 22, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 21, 2021

This PR is a step forward on #104519

It changes the package build to use the internal macro for pkg_npm

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 21, 2021
@mistic mistic requested a review from jbudz December 21, 2021 17:34
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic marked this pull request as ready for review December 21, 2021 19:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic merged commit d405027 into elastic:main Dec 22, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @kibana-ci @elasticmachine @jbudz @kibanamachine