[data views] remove _timestamp field overrides #121772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
mattkime
added
Team:AppServicesSv
Feature:Data Views
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
Dosant
approved these changes
Dec 21, 2021
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
mattkime
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2021
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Matthew Kime <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Matthew Kime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#111238 - allowed fields that start with an underscore (aside form meta fields) to be part of a data view but there was existing code that overrode the type of any field named
_timestampwhich is fine if its a date field but breaks most searches if its anything else._timestampfield was removed from ES quite a while ago so we can simply stop overriding its type - elastic/elasticsearch#18980closes: #121710
Release notes: bug fix
Allow fields named
_timestampto be non-date types