Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Visualize refactor with embeddable #12147

Closed
wants to merge 86 commits into from
Closed

[POC] Visualize refactor with embeddable #12147

wants to merge 86 commits into from

Conversation

stacey-gammon
Copy link
Contributor

Figure out what changes would be necessary when incorporating #12146 into the vis refactor. The only thing I had to add was adding getAppState in the actions.

ppisljar added 30 commits May 17, 2017 14:04
@ppisljar
converting Vis to es6 class
714fbd1
@ppisljar
moving response converter and listener defaults to vis_type
d089706
@ppisljar
move search from visualize app into visualize component
d1e8fca
@ppisljar
adding <visualization> component
442aea1
@ppisljar
introducing request and response handlers
4eedee8
@ppisljar
adding <visualization-editor> and moving it inside <visualize>
c39cfc4
@ppisljar
introducing editorType registry
ebd94c0
@ppisljar
changing vis_type definition (renaming)
31ed168
@ppisljar
removing renderbot and restructuring vis_types files
2b97505
@ppisljar
rebasing on master
a97edcf
@ppisljar
removing unused stuff from Vis
5e86a52
@ppisljar
removing unused stuff from Vis
0bda18b
@ppisljar
throwing some stuff around
2e08eb4
@ppisljar
updating vislib vis types
763a10e
@ppisljar
moving api to Vis
0b2d4e6
@ppisljar
cleanup bwc
29e68be
@ppisljar
updating vis with state
3c80c34
@ppisljar
updating editor
bf74ab4
@ppisljar
introducing promises on vis types
f475cdd
@ppisljar
updating most vis types to the new system
07d2cf5
@ppisljar
fixing issue with state type
a82c9f6
@ppisljar
template vis type should update vis on render
ebcbef8
@ppisljar
fixing visualizations without search
fab9bf9
@ppisljar
doing fetch even with none search handler
8523da6
@ppisljar
call destroy when unloading visualization
bebd0dd
@ppisljar
typo s/filter/filters
9fe05d6
@ppisljar
fixing vis type render functions
a6cf0b5
@ppisljar
adding timelion request handler and updating timelion
7a99b4a
@ppisljar
fixing typo s/Registy/Registry
4dba567
@ppisljar
updating discover page to use visualization
91d6138
ppisljar and others added 24 commits May 22, 2017 17:15
@ppisljar
adding tabify response handler and setting it as default
9c0a038
@ppisljar
moving renderCounter to <visualization>
7668217
@ppisljar
fixing default editor
c986103
@ppisljar
safeguards on angular vis type
6dd1077
@ppisljar
adding missing react factory call
27cfe41
@ppisljar
adding CATEGORY.HIDDEN
074ebdd 
(cherry picked from commit 3fb6bc9)
@ppisljar
rename savedVis to savedObj
a3f1be4 
(cherry picked from commit d11cef1)
@ppisljar
fixing state monitor
8d3664d
@ppisljar
fixing tagcloud and heatmap
721d39f
@ppisljar
fixing default editor
0c7aabb
@ppisljar
fixing react_vis_type resize method to not fire if vis is not set
117510f
@ppisljar
fixing some bugs
496d3e8
@ppisljar
dont add empty options tab
0b55fb1
@ppisljar
add isEditorMode() to Vis object
f7888c5
@ppisljar
moving vis to constructor
c4c4f2b
@thomasneirynck
make the render-method of editors and visualizations async
db6a252
@ppisljar
our types should not use async, but user is free to in his implementa…
a2e7af5 
…tions
@ppisljar
cleaning up timelion request handler
c9dd344
@ppisljar
converting tsvb - first step
da2bb34
@ppisljar
converting tsvb - first step
c84d1a1
@ppisljar
adding update method to time filter
04bfb9c
@nreese @thomasneirynck
add indexPatterns to API (elastic#12122)
812ae7b
@ppisljar
adding indexPattern to the vis.API
9fe295e
@stacey-gammon
Embeddable handlers
faae8c1 
hooking in embeddable handlers
@stacey-gammon stacey-gammon changed the title Visualize refactor with embeddable [POC] Visualize refactor with embeddable Jun 2, 2017
@thomasneirynck thomasneirynck removed their request for review June 27, 2017 20:01
@stacey-gammon stacey-gammon deleted the visualize-refactor-with-embeddable branch October 24, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stacey-gammon @ppisljar @thomasneirynck @nreese