Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] [Security Solution] updates host risk score decimal count (UI) (#119228) #121424

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ecezalp
Copy link
Contributor

@ecezalp ecezalp commented Dec 16, 2021

Backports the following commits to 7.17:

…ic#119228)

* updates host risk score decimal count

* fix function

* changes isNaN to Number.isNaN

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Ece Ozalp <[email protected]>
@ecezalp ecezalp enabled auto-merge (squash) December 16, 2021 16:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@elastic/apm-synthtrace - 18 +18
@elastic/datemath - 43 +43
@kbn/ace - 11 +11
@kbn/alerts - 9 +9
@kbn/analytics - 69 +69
@kbn/apm-config-loader - 14 +14
@kbn/apm-utils - 11 +11
@kbn/cli-dev-mode - 2 +2
@kbn/config - 52 +52
@kbn/config-schema - 107 +107
@kbn/crypto - 7 +7
@kbn/dev-utils - 214 +214
@kbn/docs-utils - 1 +1
@kbn/es-archiver - 14 +14
@kbn/es-query - 153 +153
@kbn/field-types - 16 +16
@kbn/i18n - 2 +2
@kbn/io-ts-utils - 18 +18
@kbn/legacy-logging - 27 +27
@kbn/logging - 5 +5
@kbn/mapbox-gl - 378 +378
@kbn/monaco - 38 +38
@kbn/optimizer - 45 +45
@kbn/plugin-generator - 1 +1
@kbn/plugin-helpers - 1 +1
@kbn/pm - 49 +49
@kbn/rule-data-utils - 71 +71
@kbn/securitysolution-autocomplete - 34 +34
@kbn/securitysolution-es-utils - 51 +51
@kbn/securitysolution-hook-utils - 1 +1
@kbn/securitysolution-io-ts-alerting-types - 128 +128
@kbn/securitysolution-io-ts-list-types - 419 +419
@kbn/securitysolution-io-ts-types - 23 +23
@kbn/securitysolution-io-ts-utils - 22 +22
@kbn/securitysolution-list-api - 41 +41
@kbn/securitysolution-list-constants - 9 +9
@kbn/securitysolution-list-hooks - 44 +44
@kbn/securitysolution-list-utils - 178 +178
@kbn/securitysolution-t-grid - 116 +116
@kbn/securitysolution-utils - 4 +4
@kbn/server-http-tools - 50 +50
@kbn/server-route-repository - 27 +27
@kbn/std - 63 +63
@kbn/storybook - 20 +20
@kbn/telemetry-tools - 2 +2
@kbn/test - 177 +177
@kbn/typed-react-router-config - 78 +78
@kbn/utility-types - 10 +10
@kbn/utils - 21 +21
actions - 125 +125
advancedSettings - 20 +20
alerting - 253 +253
apm - 39 +39
banners - 9 +9
bfetch - 67 +67
canvas - 8 +8
cases - 432 +432
charts - 253 +253
cloud - 22 +22
console - 13 +13
core - 1025 +1025
customIntegrations - 79 +79
dashboard - 135 +135
dashboardEnhanced - 50 +50
dashboardMode - 11 +11
data - 2819 +2819
dataEnhanced - 16 +16
dataViews - 540 +540
dataVisualizer - 84 +84
devTools - 8 +8
discover - 77 +77
discoverEnhanced - 37 +37
embeddable - 393 +393
embeddableEnhanced - 14 +14
encryptedSavedObjects - 27 +27
enterpriseSearch - 2 +2
esUiShared - 106 +106
eventLog - 84 +84
expressionError - 12 +12
expressionImage - 24 +24
expressionMetric - 25 +25
expressionMetricVis - 49 +49
expressionRepeatImage - 30 +30
expressionRevealImage - 12 +12
expressions - 1640 +1640
expressionShape - 143 +143
expressionTagcloud - 5 +5
features - 98 +98
fieldFormats - 246 +246
fileUpload - 129 +129
fleet - 1131 +1131
globalSearch - 14 +14
home - 74 +74
indexLifecycleManagement - 4 +4
indexManagement - 164 +164
indexPatternEditor - 8 +8
indexPatternFieldEditor - 39 +39
indexPatternManagement - 2 +2
infra - 22 +22
inspector - 96 +96
kibanaLegacy - 11 +11
kibanaOverview - 6 +6
kibanaReact - 245 +245
kibanaUtils - 414 +414
lens - 235 +235
licenseApiGuard - 8 +8
licenseManagement - 3 +3
licensing - 42 +42
lists - 148 +148
management - 40 +40
maps - 197 +197
mapsEms - 65 +65
mapsLegacy - 35 +35
metricsEntities - 6 +6
ml - 278 +278
monitoring - 10 +10
navigation - 31 +31
newsfeed - 17 +17
observability - 270 +270
osquery - 10 +10
presentationUtil - 151 +151
regionMap - 3 +3
remoteClusters - 4 +4
reporting - 159 +159
rollup - 21 +21
ruleRegistry - 140 +140
runtimeFields - 19 +19
savedObjects - 207 +207
savedObjectsManagement - 98 +98
savedObjectsTagging - 50 +50
savedObjectsTaggingOss - 51 +51
screenshotMode - 24 +24
security - 54 +54
securitySolution - 1312 +1312
share - 90 +90
snapshotRestore - 23 +23
spaces - 21 +21
stackAlerts - 4 +4
taskManager - 32 +32
telemetryCollectionManager - 35 +35
telemetryCollectionXpack - 1 +1
telemetryManagementSection - 10 +10
timelines - 849 +849
transform - 4 +4
triggersActionsUi - 229 +229
uiActions - 90 +90
uiActionsEnhanced - 145 +145
urlForwarding - 15 +15
usageCollection - 17 +17
visDefaultEditor - 50 +50
visTypePie - 12 +12
visTypeTable - 12 +12
visTypeTimelion - 2 +2
visTypeTimeseries - 10 +10
visTypeVega - 2 +2
visTypeVislib - 26 +26
visTypeXy - 51 +51
visualizations - 286 +286
visualize - 23 +23
total +20012

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/ace - 5 +5
@kbn/alerts - 1 +1
@kbn/config-schema - 3 +3
@kbn/dev-utils - 6 +6
@kbn/es-query - 2 +2
@kbn/mapbox-gl - 9 +9
@kbn/securitysolution-autocomplete - 1 +1
@kbn/securitysolution-io-ts-alerting-types - 1 +1
@kbn/securitysolution-io-ts-list-types - 1 +1
@kbn/std - 1 +1
@kbn/storybook - 1 +1
@kbn/test - 5 +5
@kbn/utility-types - 1 +1
@kbn/utils - 1 +1
bfetch - 1 +1
charts - 4 +4
core - 27 +27
customIntegrations - 1 +1
dashboard - 1 +1
data - 40 +40
dataViews - 5 +5
dataVisualizer - 5 +5
embeddable - 5 +5
esUiShared - 5 +5
expressions - 27 +27
fieldFormats - 7 +7
fileUpload - 4 +4
fleet - 15 +15
home - 2 +2
indexManagement - 9 +9
indexPatternEditor - 1 +1
indexPatternFieldEditor - 2 +2
inspector - 6 +6
kibanaReact - 2 +2
kibanaUtils - 3 +3
mapsEms - 1 +1
ml - 10 +10
observability - 1 +1
presentationUtil - 3 +3
savedObjects - 3 +3
savedObjectsTaggingOss - 3 +3
securitySolution - 8 +8
share - 1 +1
snapshotRestore - 1 +1
timelines - 6 +6
triggersActionsUi - 1 +1
uiActionsEnhanced - 2 +2
visTypeTimeseries - 1 +1
visualizations - 13 +13
total +264

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +60.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@elastic/apm-synthtrace - 6 +6
@kbn/analytics - 4 +4
@kbn/config - 1 +1
@kbn/config-schema - 18 +18
@kbn/es-archiver - 1 +1
@kbn/es-query - 14 +14
@kbn/i18n - 2 +2
@kbn/io-ts-utils - 2 +2
@kbn/legacy-logging - 2 +2
@kbn/logging - 37 +37
@kbn/monaco - 3 +3
@kbn/optimizer - 9 +9
@kbn/pm - 5 +5
@kbn/securitysolution-hook-utils - 1 +1
@kbn/securitysolution-list-api - 5 +5
@kbn/server-http-tools - 1 +1
@kbn/server-route-repository - 1 +1
@kbn/std - 2 +2
@kbn/test - 9 +9
@kbn/tinymath - 3 +3
@kbn/typed-react-router-config - 1 +1
@kbn/utility-types - 1 +1
actions - 8 +8
advancedSettings - 1 +1
alerting - 16 +16
apm - 41 +41
bar - 2 +2
bfetch - 2 +2
canvas - 3 +3
cases - 14 +14
charts - 3 +3
console - 1 +1
core - 30 +30
customIntegrations - 1 +1
dashboard - 10 +10
data - 48 +48
dataEnhanced - 2 +2
dataViews - 5 +5
devTools - 2 +2
discover - 7 +7
discoverEnhanced - 2 +2
embeddable - 4 +4
encryptedSavedObjects - 4 +4
esUiShared - 3 +3
eventLog - 4 +4
expressionError - 2 +2
expressionRevealImage - 3 +3
expressions - 4 +4
features - 2 +2
fieldFormats - 3 +3
fileUpload - 1 +1
fleet - 10 +10
globalSearch - 5 +5
home - 5 +5
indexManagement - 3 +3
indexPatternFieldEditor - 3 +3
infra - 3 +3
inspector - 4 +4
kibana - 930 +930
kibanaLegacy - 1 +1
kibanaReact - 5 +5
kibanaUtils - 8 +8
lens - 24 +24
licensing - 8 +8
lists - 39 +39
management - 5 +5
maps - 29 +29
metricsEntities - 1 +1
ml - 33 +33
monitoring - 2 +2
navigation - 2 +2
observability - 17 +17
presentationUtil - 5 +5
reporting - 14 +14
ruleRegistry - 7 +7
runtimeFields - 2 +2
savedObjects - 4 +4
screenshotMode - 1 +1
security - 8 +8
securitySolution - 33 +33
share - 10 +10
snapshotRestore - 1 +1
spaces - 1 +1
taskManager - 7 +7
telemetryCollectionManager - 6 +6
timelines - 25 +25
transform - 1 +1
triggersActionsUi - 18 +18
uiActions - 11 +11
uiActionsEnhanced - 9 +9
usageCollection - 2 +2
visDefaultEditor - 3 +3
visTypePie - 2 +2
visTypeTimelion - 2 +2
visTypeTimeseries - 3 +3
visTypeVislib - 1 +1
visTypeXy - 5 +5
visualizations - 16 +16
visualize - 1 +1
total +1691

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
_data_stream_timestamp - 1 +1
_doc_count - 1 +1
_tier - 1 +1
action - 6 +6
action_task_params - 3 +3
alert - 35 +35
api_key_pending_invalidation - 3 +3
apm-indices - 7 +7
apm-server-schema - 2 +2
application_usage_daily - 2 +2
canvas-element - 8 +8
canvas-workpad - 5 +5
canvas-workpad-template - 8 +8
cases - 40 +40
cases-comments - 30 +30
cases-configure - 19 +19
cases-connector-mappings - 6 +6
cases-user-actions - 11 +11
config - 2 +2
coreMigrationVersion - 1 +1
dashboard - 17 +17
endpoint:user-artifact - 10 +10
endpoint:user-artifact-manifest - 7 +7
epm-packages - 19 +19
epm-packages-assets - 8 +8
event_loop_delays_daily - 2 +2
exception-list - 41 +41
exception-list-agnostic - 41 +41
file-upload-usage-collection-telemetry - 3 +3
fleet-agent-actions - 9 +9
fleet-agents - 22 +22
fleet-enrollment-api-keys - 10 +10
fleet-preconfiguration-deletion-record - 2 +2
graph-workspace - 10 +10
index-pattern - 3 +3
ingest_manager_settings - 4 +4
ingest-agent-policies - 17 +17
ingest-outputs - 10 +10
ingest-package-policies - 38 +38
kql-telemetry - 3 +3
legacy-url-alias - 5 +5
lens - 6 +6
lens-ui-telemetry - 5 +5
map - 7 +7
ml-job - 6 +6
ml-module - 11 +11
monitoring-telemetry - 2 +2
namespace - 1 +1
namespaces - 1 +1
originId - 1 +1
osquery-manager-usage-metric - 3 +3
osquery-pack - 14 +14
osquery-saved-query - 11 +11
query - 6 +6
references - 4 +4
sample-data-telemetry - 3 +3
search - 10 +10
search-session - 15 +15
security-rule - 4 +4
security-solution-signals-migration - 11 +11
siem-detection-engine-rule-actions - 9 +9
siem-detection-engine-rule-status - 11 +11
siem-ui-timeline - 96 +96
siem-ui-timeline-note - 7 +7
siem-ui-timeline-pinned-event - 6 +6
space - 9 +9
tag - 4 +4
telemetry - 9 +9
type - 1 +1
ui-counter - 2 +2
ui-metric - 2 +2
updated_at - 1 +1
upgrade-assistant-ml-upgrade-operation - 9 +9
upgrade-assistant-reindex-operation - 18 +18
upgrade-assistant-telemetry - 4 +4
url - 9 +9
usage-counters - 2 +2
visualization - 9 +9
total +801
Unknown metric groups

API count

id before after diff
@elastic/apm-synthtrace - 18 +18
@elastic/datemath - 44 +44
@kbn/ace - 11 +11
@kbn/alerts - 9 +9
@kbn/analytics - 69 +69
@kbn/apm-config-loader - 14 +14
@kbn/apm-utils - 11 +11
@kbn/cli-dev-mode - 2 +2
@kbn/config - 73 +73
@kbn/config-schema - 109 +109
@kbn/crypto - 13 +13
@kbn/dev-utils - 280 +280
@kbn/docs-utils - 1 +1
@kbn/es-archiver - 27 +27
@kbn/es-query - 205 +205
@kbn/field-types - 20 +20
@kbn/i18n - 2 +2
@kbn/io-ts-utils - 18 +18
@kbn/legacy-logging - 28 +28
@kbn/logging - 30 +30
@kbn/mapbox-gl - 467 +467
@kbn/monaco - 38 +38
@kbn/optimizer - 45 +45
@kbn/plugin-generator - 1 +1
@kbn/plugin-helpers - 1 +1
@kbn/pm - 63 +63
@kbn/rule-data-utils - 74 +74
@kbn/securitysolution-autocomplete - 47 +47
@kbn/securitysolution-es-utils - 57 +57
@kbn/securitysolution-hook-utils - 8 +8
@kbn/securitysolution-io-ts-alerting-types - 147 +147
@kbn/securitysolution-io-ts-list-types - 428 +428
@kbn/securitysolution-io-ts-types - 45 +45
@kbn/securitysolution-io-ts-utils - 28 +28
@kbn/securitysolution-list-api - 42 +42
@kbn/securitysolution-list-constants - 23 +23
@kbn/securitysolution-list-hooks - 56 +56
@kbn/securitysolution-list-utils - 223 +223
@kbn/securitysolution-t-grid - 120 +120
@kbn/securitysolution-utils - 6 +6
@kbn/server-http-tools - 53 +53
@kbn/server-route-repository - 28 +28
@kbn/std - 96 +96
@kbn/storybook - 20 +20
@kbn/telemetry-tools - 2 +2
@kbn/test - 200 +200
@kbn/typed-react-router-config - 78 +78
@kbn/utility-types - 29 +29
@kbn/utils - 31 +31
actions - 125 +125
advancedSettings - 23 +23
alerting - 261 +261
apm - 39 +39
banners - 9 +9
bfetch - 76 +76
canvas - 9 +9
cases - 476 +476
charts - 285 +285
cloud - 22 +22
console - 13 +13
core - 2308 +2308
customIntegrations - 95 +95
dashboard - 148 +148
dashboardEnhanced - 51 +51
dashboardMode - 11 +11
data - 3213 +3213
dataEnhanced - 16 +16
dataViews - 682 +682
dataVisualizer - 84 +84
devTools - 10 +10
discover - 103 +103
discoverEnhanced - 39 +39
embeddable - 469 +469
embeddableEnhanced - 14 +14
encryptedSavedObjects - 29 +29
enterpriseSearch - 2 +2
esUiShared - 110 +110
eventLog - 84 +84
expressionError - 12 +12
expressionImage - 24 +24
expressionMetric - 30 +30
expressionMetricVis - 49 +49
expressionRepeatImage - 30 +30
expressionRevealImage - 12 +12
expressions - 2086 +2086
expressionShape - 143 +143
expressionTagcloud - 5 +5
features - 216 +216
fieldFormats - 284 +284
fileUpload - 129 +129
fleet - 1234 +1234
globalSearch - 68 +68
home - 96 +96
indexLifecycleManagement - 4 +4
indexManagement - 169 +169
indexPatternEditor - 13 +13
indexPatternFieldEditor - 42 +42
indexPatternManagement - 2 +2
infra - 25 +25
inspector - 123 +123
kibanaLegacy - 14 +14
kibanaOverview - 6 +6
kibanaReact - 283 +283
kibanaUtils - 607 +607
lens - 253 +253
licenseApiGuard - 8 +8
licenseManagement - 3 +3
licensing - 117 +117
lists - 155 +155
management - 40 +40
maps - 198 +198
mapsEms - 65 +65
mapsLegacy - 35 +35
metricsEntities - 9 +9
ml - 282 +282
monitoring - 10 +10
navigation - 31 +31
newsfeed - 17 +17
observability - 271 +271
osquery - 10 +10
presentationUtil - 178 +178
regionMap - 3 +3
remoteClusters - 4 +4
reporting - 162 +162
rollup - 21 +21
ruleRegistry - 163 +163
runtimeFields - 24 +24
savedObjects - 221 +221
savedObjectsManagement - 111 +111
savedObjectsTagging - 54 +54
savedObjectsTaggingOss - 90 +90
screenshotMode - 29 +29
security - 117 +117
securitySolution - 1366 +1366
share - 143 +143
snapshotRestore - 23 +23
spaces - 208 +208
stackAlerts - 4 +4
taskManager - 70 +70
telemetry - 41 +41
telemetryCollectionManager - 35 +35
telemetryCollectionXpack - 1 +1
telemetryManagementSection - 11 +11
timelines - 972 +972
transform - 4 +4
triggersActionsUi - 238 +238
uiActions - 129 +129
uiActionsEnhanced - 203 +203
urlForwarding - 15 +15
usageCollection - 58 +58
visDefaultEditor - 57 +57
visTypePie - 12 +12
visTypeTable - 12 +12
visTypeTimelion - 2 +2
visTypeTimeseries - 10 +10
visTypeVega - 2 +2
visTypeVislib - 27 +27
visTypeXy - 57 +57
visualizations - 304 +304
visualize - 24 +24
total +24661

References to deprecated APIs

id before after diff
actions - 15 +15
advancedSettings - 2 +2
alerting - 20 +20
apm - 77 +77
canvas - 67 +67
cases - 151 +151
cloud - 1 +1
console - 1 +1
crossClusterReplication - 1 +1
dashboard - 244 +244
dashboardEnhanced - 13 +13
dashboardMode - 1 +1
data - 463 +463
dataEnhanced - 49 +49
dataViews - 235 +235
dataVisualizer - 242 +242
discover - 1810 +1810
discoverEnhanced - 21 +21
embeddable - 7 +7
encryptedSavedObjects - 4 +4
enterpriseSearch - 3 +3
fileUpload - 1 +1
fleet - 39 +39
graph - 168 +168
home - 1 +1
indexLifecycleManagement - 1 +1
indexPatternEditor - 85 +85
indexPatternFieldEditor - 156 +156
indexPatternManagement - 498 +498
infra - 266 +266
ingestPipelines - 2 +2
inputControlVis - 325 +325
kibanaOverview - 2 +2
kibanaUsageCollection - 1 +1
lens - 353 +353
licenseManagement - 1 +1
logstash - 2 +2
management - 2 +2
maps - 1667 +1667
ml - 80 +80
monitoring - 53 +53
observability - 178 +178
osquery - 2 +2
painlessLab - 3 +3
presentationUtil - 13 +13
regionMap - 4 +4
remoteClusters - 1 +1
reporting - 30 +30
rollup - 1 +1
savedObjects - 44 +44
savedObjectsManagement - 110 +110
savedObjectsTagging - 1 +1
savedObjectsTaggingOss - 5 +5
searchprofiler - 3 +3
security - 71 +71
securitySolution - 991 +991
snapshotRestore - 1 +1
spaces - 6 +6
stackAlerts - 183 +183
tileMap - 4 +4
timelines - 84 +84
transform - 148 +148
upgradeAssistant - 7 +7
uptime - 26 +26
urlDrilldown - 18 +18
visDefaultEditor - 213 +213
visTypePie - 17 +17
visTypeTable - 1 +1
visTypeTimelion - 45 +45
visTypeTimeseries - 337 +337
visTypeVega - 35 +35
visTypeVislib - 1 +1
visTypeXy - 6 +6
visualizations - 102 +102
visualize - 89 +89
watcher - 2 +2
total +9912

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ecezalp ecezalp merged commit 88fbedb into elastic:7.17 Dec 16, 2021
@ghost
Copy link

ghost commented Jan 20, 2022

Hi @MadameSheema,

We have validated above issue on self managed 7.17.0 BC2 build setup and it's working fine. ✅

Build Info
Version: 7.17.0 BC2
Build: 46488
Commit: a6fd029464413f6979099d7a3d4232c5194a269d

Screenshot:

image

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants