Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data does not wrap on alert details inside enriched data block #121292

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix data does not wrap on alert details inside enriched data block #121292

merged 1 commit into from
Dec 21, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Dec 15, 2021 •
edited
Loading

issue: #119418

Summary

  • Add eui-textBreakWord utility class to enforce the field content to break.
  • Add applyWidthAndPadding prop to ActionCell to make more space for the content
  • Overwrite hoverActions style to display ActionCell on hovering and make it consistent with other flyout fields.

Before fix
Screenshot 2021-12-15 at 13 40 50

After fix
Screenshot 2021-12-20 at 14 38 52
Screenshot 2021-12-20 at 14 39 07
Screenshot 2021-12-20 at 14 38 39
Screenshot 2021-12-20 at 14 38 10

@machadoum machadoum self-assigned this Dec 15, 2021
@machadoum machadoum requested a review from a team as a code owner December 15, 2021 12:43
@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum machadoum added v7.17.0 bug Fixes for quality problems that affect the customer experience release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Dec 15, 2021
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

janmonschke
janmonschke approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@machadoum machadoum force-pushed the siem-explore-issue-119418 branch from acfdbc2 to 54af0cc Compare December 20, 2021 14:15
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +287.0B

History

  • 💚 Build #14158 succeeded acfdbc2bfabf60a01a9ed90b9f8320e046b67a1d
  • 💚 Build #13363 succeeded 7fb322173141a83e9ce8a2aed6894d6277142cd9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 33c367b into elastic:main Dec 21, 2021
mibragimov pushed a commit to mibragimov/kibana that referenced this pull request Dec 22, 2021
@machadoum
Fix Data does not wrap on resolution change for indicator rule under …
d16967e 
…alert details (elastic#121292)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 23, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

10 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 121292 or prevent reminders by adding the backport:skip label.

@MadameSheema
Copy link
Member

@machadoum has this PR been backported to 7.17??

@machadoum machadoum mentioned this pull request Jan 10, 2022
Merged
@machadoum
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

@machadoum
Copy link
Member Author

@MadameSheema No. I just did it here #122536

@machadoum machadoum mentioned this pull request Jan 10, 2022
Merged
@machadoum
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

machadoum added a commit to machadoum/kibana that referenced this pull request Jan 10, 2022
@machadoum
Fix Data does not wrap on resolution change for indicator rule under …
9094e22 
…alert details (elastic#121292)

(cherry picked from commit 33c367b)
machadoum added a commit to machadoum/kibana that referenced this pull request Jan 10, 2022
@machadoum
Fix Data does not wrap on resolution change for indicator rule under …
57d517a 
…alert details (elastic#121292)

(cherry picked from commit 33c367b)
machadoum added a commit that referenced this pull request Jan 10, 2022
@machadoum
Fix Data does not wrap on resolution change for indicator rule under …
aa9ea2b 
…alert details (#121292) (#122536)

(cherry picked from commit 33c367b)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2022
machadoum added a commit that referenced this pull request Jan 10, 2022
@machadoum
Fix Data does not wrap on resolution change for indicator rule under …
c50f073 
…alert details (#121292) (#122543)

(cherry picked from commit 33c367b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

@janmonschke janmonschke janmonschke approved these changes

Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v7.17.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @MadameSheema @janmonschke @angorayc