Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add previous time shift back #121284

Merged
merged 12 commits into from
Jan 12, 2022
Merged

[Lens] Add previous time shift back #121284

merged 12 commits into from
Jan 12, 2022

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Dec 15, 2021 •
edited
Loading

Fixes #104259

This PR adds back the "previous" time shift, but only if there are no date histograms in the current chart.

Screenshot 2021-12-15 at 15 54 42

Screenshot 2021-12-15 at 18 35 25

Screenshot 2021-12-15 at 18 35 46

@flash1293 flash1293 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv backport:skip This commit does not require backporting v8.1.0 labels Dec 15, 2021
@flash1293 flash1293 marked this pull request as ready for review December 16, 2021 11:45
@flash1293 flash1293 requested a review from a team as a code owner December 16, 2021 11:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@dej611
Copy link
Contributor

dej611 commented Dec 30, 2021

@elasticmachine merge upstream

dej611
dej611 reviewed Dec 30, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing it I could not find the Previous entry in the Time shift option.
Typing previous makes it magically appear it tho:
previous_secret_input

@dej611
Copy link
Contributor

dej611 commented Jan 3, 2022

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

Good point @dej611 , it's treated like an invalid value now (and also it shows the red error border):
Screenshot 2022-01-05 at 13 18 40

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1021.1KB 1022.1KB +1.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611
dej611 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and previous issue was fixed.

@flash1293 flash1293 merged commit 339f721 into elastic:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Time shift previous period
5 participants
@flash1293 @elasticmachine @dej611 @kibana-ci @kibanamachine