Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clickSelector a retry in case it fails the first time #12125

Closed
wants to merge 2 commits into from

Conversation

stacey-gammon
Copy link
Contributor

Another attempt to fix my latest encounter with #12014

Based on the output I saw:

60          │ debg  Kibana uiSettings are in elasticsearch and the server is reporting a green status
05:36:07.460        │ debg  click Visualize tab
05:36:09.982        │ debg  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/screenshots/failure/dashboard app dashboard view edit mode create new dashboard opens in edit mode.png"
05:36:10.076      └- ✖ fail: "dashboard app dashboard view edit mode create new dashboard opens in edit mode"
05:36:10.076      │        [POST http://localhost:9515/session/771e363c16d80ac8e4a6f3f85e3e1152/element/0.8652604812149967-1/click] element not visible
05:36:10.076      │         (Session info: chrome=56.0.2924.87)
05:36:10.076      │         (Driver info: chromedriver=2.29.461571 (8a88bbe0775e2a23afda0ceaf2ef7ee74e822cc5),platform=Linux 4.4.0-45-generic x86_64)
05:36:10.076      │         at Server._post (test/functional/services/remote/verbose_remote_logging.js:15:21)
05:36:10.077      │         at runRequest (node_modules/leadfoot/Session.js:92:40)
05:36:10.077      │         at node_modules/leadfoot/Session.js:113:39
05:36:10.077      │         at new Promise (node_modules/dojo/Promise.js:172:17)
05:36:10.078      │         at Session._post (node_modules/leadfoot/Session.js:67:10)
05:36:10.078      │         at Element._post (node_modules/leadfoot/Element.js:23:31)
05:36:10.078      │         at Element.click (node_modules/leadfoot/Element.js:191:15)
05:36:10.078      │         at Command.<anonymous> (node_modules/leadfoot/Command.js:680:19)
05:36:10.078      │         at node_modules/dojo/Promise.js:156:41
05:36:10.078      │         at run (node_modules/dojo/Promise.js:51:33)
05:36:10.078      │         at node_modules/dojo/nextTick.js:35:17

And the screenshot:
dashboard app dashboard view edit mode create new dashboard opens in edit mode 6

It looks like the first attempt to clickVisualize failed with element not visible. The visualize link is visible but I'm hoping wrapping the clickSelector in a retry might avoid this in the future. Also spitting out some debug statements since there wasn't much to go on.

@stacey-gammon
Copy link
Contributor Author

passed once,

Jenkins, test this.

@stacey-gammon
Copy link
Contributor Author

The important parts of this PR were merged by another PR, so closing as it shouldn't be necessary anymore.

@stacey-gammon stacey-gammon deleted the more-flaky-tests branch October 24, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant