Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Host risk information flyout to Host risk KPI panel #121075

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Add Host risk information flyout to Host risk KPI panel #121075

merged 6 commits into from
Dec 22, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Dec 13, 2021 •
edited
Loading

issue: #119024

Summary

Add an info button to the Hosts KPI panel beside the inspect button. When the button is clicked it opens a flyout containing information about host risk calculation.

Screenshot 2021-12-13 at 13 58 43

Screenshot 2021-12-13 at 13 57 30

How to test it

Enable the feature flag riskyHostsEnabled

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum requested a review from a team as a code owner December 13, 2021 13:00
@machadoum machadoum self-assigned this Dec 13, 2021
@machadoum machadoum changed the title Siem explore issue 119024 Add Host risk information flyout to Host risk KPI panel Dec 13, 2021
@machadoum machadoum added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:feature Makes this part of the condensed release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Dec 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum machadoum force-pushed the siem-explore-issue-119024-3 branch from 30cbbfb to e26cca3 Compare December 14, 2021 10:44
@machadoum machadoum force-pushed the siem-explore-issue-119024-3 branch from e26cca3 to 3ef7933 Compare December 15, 2021 11:51
@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

@machadoum machadoum force-pushed the siem-explore-issue-119024-3 branch from 38215f9 to d18437d Compare December 20, 2021 17:03
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS Misc Functional Tests / Saved Objects Management saved objects management with hidden types Delete modal should display a warning then trying to delete hidden saved objects

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2829 2832 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +4.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 243.5KB 243.7KB +114.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

stephmilovic
stephmilovic reviewed Dec 21, 2021
View reviewed changes
x-pack/plugins/security_solution/cypress/integration/hosts/risky_hosts_kpi.spec.ts
@@ -10,7 +10,7 @@ import { loginAndWaitForPage } from '../../tasks/login';
import { HOSTS_URL } from '../../urls/navigation';

describe('RiskyHosts KPI', () => {
it('it renders', () => {
it('renders', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

stephmilovic
stephmilovic approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @machadoum
a

@machadoum machadoum merged commit 653cbe1 into elastic:main Dec 22, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 22, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@angorayc angorayc angorayc approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @stephmilovic @kibana-ci @kibanamachine @angorayc