[RAC][Observability] stop indexing severity value in uptime #120873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
mgiota
added
Team: Actionable Observability - DEPRECATED
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @mgiota |
dominiqueclarke
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
LGTM.
Regarding the reason message: Severity is used in the construction of the duration_anomaly reason message. However, this reason message is constructed on the server, so it is not necessary to index it at this time. If the reason message construction is ever moved to public, severity would need to be indexed.
Severity is not used in the reason message of tls or monitor status checks.
|
@dominiqueclarke Exactly thanks a lot, this confirms my thoughts! |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2021
Co-authored-by: mgiota <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120868
Notes for the reviewer
Could you verify that the severity
indexed valueis not used in the construction of the reason message? I didn't find any usage of it in the reason, but I would like a confirmation.