Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Replace usage of deprecated filter types #120762

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[Infra UI] Replace usage of deprecated filter types #120762

merged 2 commits into from
Dec 9, 2021

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Dec 8, 2021 •
edited
Loading

Summary

Fixes #120079.

Testing

@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 8, 2021
@Kerry350 Kerry350 requested a review from a team December 8, 2021 14:03
@Kerry350 Kerry350 self-assigned this Dec 8, 2021
@Kerry350 Kerry350 mentioned this pull request Dec 8, 2021
Closed
@weltenwort weltenwort self-requested a review December 8, 2021 14:25
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 991.3KB 991.3KB +9.0B
Unknown metric groups

References to deprecated APIs

id before after diff
infra 259 237 -22

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

weltenwort
weltenwort approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍 I tried to run the dev-docs report that generates the list of usages of deprecated APIs on the branch locally, but couldn't get it to work. 🤷

@weltenwort
Copy link
Member

I was able to rebuild the dev-docs and confirm that the compiler can't find any remaining references 🎉

@Kerry350 Kerry350 marked this pull request as ready for review December 9, 2021 13:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@Kerry350 Kerry350 merged commit 6d732a1 into elastic:main Dec 9, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 9, 2021
@Kerry350 @kibanamachine
[Infra UI] Replace usage of deprecated filter types (elastic#120762)
c07d0d8 
* Replace usage of deprecated filter types
@kibanamachine kibanamachine mentioned this pull request Dec 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 9, 2021
@kibanamachine @Kerry350
[Infra UI] Replace usage of deprecated filter types (#120762) (#120899)
661ecaf 
* Replace usage of deprecated filter types

Co-authored-by: Kerry Gallagher <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@Kerry350 @TinLe
[Infra UI] Replace usage of deprecated filter types (elastic#120762)
c78861c 
* Replace usage of deprecated filter types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees

@Kerry350 Kerry350

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Replace usage of deprecated filter types
5 participants
@Kerry350 @kibana-ci @weltenwort @elasticmachine @kibanamachine