Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding search source persistable state interface #120461

Merged
merged 3 commits into from
Dec 9, 2021
Merged

adding search source persistable state interface #120461

merged 3 commits into from
Dec 9, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Dec 6, 2021 •
edited
Loading

Summary

Adds persistable state interface implementation to search source service

resolves #106517

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar requested a review from a team as a code owner December 6, 2021 10:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@ppisljar ppisljar added v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 6, 2021
@ppisljar ppisljar force-pushed the searchsource/persistablestate branch from cfccf2e to 4127e96 Compare December 8, 2021 11:18
@ppisljar ppisljar force-pushed the searchsource/persistablestate branch 3 times, most recently from 5848e3c to f6b737c Compare December 8, 2021 14:32
@ppisljar ppisljar force-pushed the searchsource/persistablestate branch from f6b737c to 9b5931a Compare December 9, 2021 07:20
@ppisljar ppisljar requested a review from a team as a code owner December 9, 2021 07:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2904 2876 -28

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 442.9KB 443.4KB +430.0B
Unknown metric groups

API count

id before after diff
data 3318 3276 -42

History

  • 💔 Build #12141 failed f6b737c4ad0db60486ebe2269b3936cf44084520
  • 💔 Build #12125 failed 5848e3cbc286c07e625a2d8587eb7cf204b1f584
  • 💔 Build #12099 failed 37416948aa5e02e8efc23b2230716b4eb45f0e47
  • 💔 Build #12078 failed 4127e96cfbf7a68c78ce8109eb98ac433fc23de5
  • 💔 Build #12073 failed cfccf2e476c27fb6a295bb7e042ec014c65f6f17

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dokmic
dokmic approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ppisljar ppisljar merged commit d1774fe into elastic:main Dec 9, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 9, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@ppisljar @TinLe
adding search source persistable state interface (elastic#120461)
6955cbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokmic dokmic dokmic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PersistableState] searchsource should implement persistablestateservice interface
5 participants
@ppisljar @elasticmachine @kibana-ci @dokmic @kibanamachine