-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Beats tutorials for security on by default #120388
Update Beats tutorials for security on by default #120388
Conversation
defaultMessage: | ||
'First time using Filebeat? See the [Quick Start]({guideLinkUrl}).\n\ | ||
export const createFilebeatInstructions = (context: TutorialContext) => { | ||
const SSL_DOC_URL = `https://www.elastic.co/guide/en/beats/filebeat/${context.kibanaVersion}/configuration-ssl.html#ca-sha256`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's where we use the Kibana version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another use case for #95389
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the Kibana version to the tutorials seems safe enough.
textPost: i18n.translate( | ||
'home.tutorials.common.filebeatInstructions.config.osxTextPostMarkdown', | ||
{ | ||
defaultMessage: | ||
'Where {passwordTemplate} is the password of the `elastic` user, {esUrlTemplate} is the URL of \ | ||
Elasticsearch, and {kibanaUrlTemplate} is the URL of Kibana. To [configure SSL]({configureSslUrl}) with the \ | ||
default certificate generated by Elasticsearch, add its fingerprint in {esCertFingerprintTemplate} and set the \ | ||
verification mode to {selfSignedCaTemplate}.', | ||
values: { | ||
passwordTemplate: '`<password>`', | ||
esUrlTemplate: '`<es_url>`', | ||
kibanaUrlTemplate: '`<kibana_url>`', | ||
configureSslUrl: SSL_DOC_URL, | ||
esCertFingerprintTemplate: '`<es cert fingerprint>`', | ||
selfSignedCaTemplate: '`self_signed_ca`', | ||
}, | ||
} | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here's where we actually update the instructions (similar below for each OS). Apologize for all the whitespace changes 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the kibana version makes sense and, yes, this is another use-case for server-side doclinks.
nit: we need to make sure the tutorials give info about what is required and what isn't. I imagine someone going through a tutorial to get their data indexed and only finding out later that they missed a required config.
{ | ||
defaultMessage: | ||
'Where {passwordTemplate} is the password of the `elastic` user, {esUrlTemplate} is the URL of \ | ||
Elasticsearch, and {kibanaUrlTemplate} is the URL of Kibana. To [configure SSL]({configureSslUrl}) with the \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention when configuring SSL is required for the deployment, if possible. Tutorials help guide folks through the process flow and giving more information around what is required and what isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment to the yaml block that indicates this, let me know what you think. Additionally, the docs that we're linking to here will be updated with additional information before the 8.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mostlyjason Feel free to let me know if you think we should make any adjustments to the copy here.
{ | ||
defaultMessage: | ||
'Where {passwordTemplate} is the password of the `elastic` user, {esUrlTemplate} is the URL of \ | ||
Elasticsearch, and {kibanaUrlTemplate} is the URL of Kibana. To [configure SSL]({configureSslUrl}) with the \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about guiding folks about required vs optional config
{ | ||
defaultMessage: | ||
'Where {passwordTemplate} is the password of the `elastic` user, {esUrlTemplate} is the URL of \ | ||
Elasticsearch, and {kibanaUrlTemplate} is the URL of Kibana. To [configure SSL]({configureSslUrl}) with the \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional or required?
adb2809
to
abdc9a2
Compare
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the unused i18n keys are removed
src/plugins/home/server/services/tutorials/tutorials_registry.ts
Outdated
Show resolved
Hide resolved
I've updated this to use the new |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @joshdover |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Josh Dover <[email protected]>
Summary
Adds YAML block, copy, and doc links to on-prem Beats tutorials about how to configure Beats for the self-signed cert generated by Elasticsearch in secure-by-default mode for 8.0. There's a lot of whitespace changes and it's all mostly copy and paste, not nearly as big as looks.
Checklist
Delete any items that are not applicable to this PR.