[Fleet] Re-enable registry version check #120045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
v8.0.0
release_note:skip
jen-huang
removed
the
auto-backport
…unctional tests" This reverts commit 2fd4ec1.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jen-huang |
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
changed the title
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Dec 2, 2021
sorenlouv
reviewed
Dec 2, 2021
| @@ -13,7 +13,7 @@ import { packageRegistryPort } from './ftr_config'; | |||
| import { FtrProviderContext } from './ftr_provider_context'; | |||
|
|
|||
| export const dockerImage = | |||
| 'docker.elastic.co/package-registry/distribution@sha256:13d9996dd24161624784704e080f5f5b7f0ef34ff0d9259f8f05010ccae00058'; | |||
| 'docker.elastic.co/package-registry/distribution@sha256:de952debe048d903fc73e8a4472bb48bb95028d440cba852f21b863d47020c61'; | |||
There was a problem hiding this comment.
Would it make sense to share this sha between fleet and apm so we won't forget to update it here next time it's bumped in fleet?
There was a problem hiding this comment.
I opened #120235 for this
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* Re-enable registry version check * Update registry image * Use dockerized registry for base x-pack api integration and functional tests * Revert "Use dockerized registry for base x-pack api integration and functional tests" This reverts commit 2fd4ec1.
|
@jen-huang Did you mean to backport this to 8.0? Afaict it was never backported but the labels suggests it should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #117107. Put back the registry Kibana version check. The check is still skipped for
mainbranch for development purposes - this is unchanged.Backport PR: #120049
^ This was done manually as the 8.0 branch is the one that would actually be impacted by this :)