[RAC] fix failing alerts table pagination functional tests #119985
Conversation
ersin-erdal
added
release_note:fix
v8.0.0
auto-backport
ersin-erdal
force-pushed
the
113486-fix-failing-pagination-tests
branch
from
0fcfc34
to
124eaeb
Compare
| @@ -25,6 +25,12 @@ const ACTION_COLUMN_INDEX = 1; | |||
|
|
|||
| type WorkflowStatus = 'open' | 'acknowledged' | 'closed'; | |||
|
|
|||
| export enum AlertStatus { | |||
| all = 'all', | |||
| active = 'active', | |||
There was a problem hiding this comment.
@ersin-erdal I suggest you import active and recovered values from https://github.com/elastic/kibana/blob/main/packages/kbn-rule-data-utils/src/alerts_as_data_status.ts
import {
ALERT_STATUS_ACTIVE,
ALERT_STATUS_RECOVERED,
} from '@kbn/rule-data-utils/alerts_as_data_status';
There was a problem hiding this comment.
i tried that but my IDE complained about it. it says that the folder is not in the root!
I think that's why the WorkflowStatus was also created there again.
There was a problem hiding this comment.
Aaah, i imported it directly! that's why it complained...
Fixing it. Thank you :)
|
@ersin-erdal LGTM! I left one comment regarding importing active and recovered from a kbn package. |
| @@ -192,7 +198,6 @@ export function ObservabilityAlertsCommonProvider({ | |||
| const viewRuleDetailsLinkClick = async () => { | |||
| return await (await testSubjects.find(VIEW_RULE_DETAILS_FLYOUT_SELECTOR)).click(); | |||
| }; | |||
|
|
|||
| // Workflow status | |||
| const setWorkflowStatusForRow = async (rowIndex: number, workflowStatus: WorkflowStatus) => { | |||
There was a problem hiding this comment.
@ersin-erdal I see you removed workflow status related code. Do we still need this? Can we remove?
There was a problem hiding this comment.
This might require bigger refactoring, since this function might be used in other files as well. I live it up to you to decide if you want to do this refactoring as part of this PR
There was a problem hiding this comment.
Yes i tried to get rid of it but a lot of functional tests failed! then i put it back.
It requires its own issue...
| @@ -25,6 +25,12 @@ const ACTION_COLUMN_INDEX = 1; | |||
|
|
|||
| type WorkflowStatus = 'open' | 'acknowledged' | 'closed'; | |||
There was a problem hiding this comment.
@ersin-erdal Workflow status leftover. Can we remove this?
There was a problem hiding this comment.
No unfortunately.
I tried to remove them as i said but setWorkflowStatusForRow and setWorkflowStatusFilter methods which requires that type are used in some other places...
There was a problem hiding this comment.
@ersin-erdal I had the same issue. WorkflowStatus code is nested in many places.
| @@ -266,6 +295,9 @@ export function ObservabilityAlertsCommonProvider({ | |||
| setWorkflowStatusForRow, | |||
There was a problem hiding this comment.
Same comment as above regarding remove workflowStatus leftovers
There was a problem hiding this comment.
used by other tests... :)
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ersin-erdal |
💔 Backport failed
To backport manually run: |
…19985) * [RAC] fix failing alerts table pagination functional tests # Conflicts: # x-pack/test/observability_functional/apps/observability/alerts/index.ts
…19985) * [RAC] fix failing alerts table pagination functional tests # Conflicts: # x-pack/test/observability_functional/apps/observability/alerts/index.ts
…19985) * [RAC] fix failing alerts table pagination functional tests
|
Pinging @elastic/apm-ui (Team:apm) |
…19985) * [RAC] fix failing alerts table pagination functional tests
Summary
Fixes: #113486
Alerts table pagination functional tests were failing.