Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/analytics #119869

Merged
merged 3 commits into from
Nov 30, 2021
Merged

chore(NA): splits types from code on @kbn/analytics #119869

merged 3 commits into from
Nov 30, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 29, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 29, 2021
@mistic mistic requested a review from jbudz November 29, 2021 17:50
@mistic
Copy link
Member Author

mistic commented Nov 29, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@mistic mistic marked this pull request as ready for review November 29, 2021 20:31
@mistic mistic requested review from a team as code owners November 29, 2021 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 894 895 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 5001000 into elastic:main Nov 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
@mistic @kibanamachine
chore(NA): splits types from code on @kbn/analytics (elastic#119869)
dc0c6c0
@kibanamachine kibanamachine mentioned this pull request Nov 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 30, 2021
@kibanamachine @mistic
chore(NA): splits types from code on @kbn/analytics (#119869) (#119969)
1aa070d 
Co-authored-by: Tiago Costa <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@mistic @TinLe
chore(NA): splits types from code on @kbn/analytics (elastic#119869)
91565a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@jbudz jbudz jbudz approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mistic @kibanamachine @elasticmachine @kibana-ci @tylersmalley @jbudz @Bamieh