-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add missing package policies for managed preconfigured policies #119488
Merged
nchaulet
merged 5 commits into
elastic:main
from
nchaulet:feature-add-missing-package-policies-managed
Nov 24, 2021
Merged
[Fleet] Add missing package policies for managed preconfigured policies #119488
nchaulet
merged 5 commits into
elastic:main
from
nchaulet:feature-add-missing-package-policies-managed
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
auto-backport
Deprecated - use backport:version if exact versions are needed
v8.1.0
labels
Nov 23, 2021
…sing-package-policies-managed
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and LGTM 🚀
…sing-package-policies-managed
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 24, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2021
…es (#119488) (#119671) Co-authored-by: Nicolas Chaulet <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.16.4
v7.17.1
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #113921
Change the behavior of the preconfiguration service to allow to add new package policy to an already created policy.
Also I removed the deletion of the policy in case an error happen during the package policy creation as this new behavior will allow to get the package policy on the next call to setup.
How to tests
From a new kibana ES environment
start you kibana a first time with that config
Than restart Kibana with that config, you should see an APM package policy in your policy