Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Changes index pattern to data views in intro docs #119403

Merged
merged 5 commits into from
Nov 29, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 22, 2021

Summary

This PR changes index pattern to data views in:

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 22, 2021
@gchaps gchaps marked this pull request as ready for review November 23, 2021 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested a review from jrodewig November 24, 2021 20:42
@gchaps
Copy link
Contributor Author

gchaps commented Nov 29, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gchaps gchaps requested a review from KOTungseth November 29, 2021 17:54
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchaps gchaps merged commit 50c0264 into elastic:main Nov 29, 2021
@gchaps gchaps deleted the docs/change-index-pattern-in-intro-docs branch November 29, 2021 19:47
gchaps added a commit to gchaps/kibana that referenced this pull request Nov 29, 2021
)

* [DOCS] Changes index pattern to data views in intro docs

* [DOCS] Updates image of data views UI

* [DOCS] Removes faulty sentence

* [DOCS] removes sentence about index patterns

Co-authored-by: Kibana Machine <[email protected]>
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the section on cross-cluster search needs a small update. Otherwise LGTM.

Comment on lines +90 to 91
you can create a {data-source} to search across the clusters of your choosing. Use the
same syntax that you use in a raw {ccs} request in {es}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this makes sense with the new changes. I've left a couple of suggestion to fix it up.

Suggested change
you can create a {data-source} to search across the clusters of your choosing. Use the
same syntax that you use in a raw {ccs} request in {es}:
you can create a {data-source} to search across the clusters of your choosing.
You specify data streams, indices, and aliases in a remote cluster using the
following syntax:

same syntax that you use in a raw {ccs} request in {es}:

```ts
<cluster-names>:<pattern>
<cluster-names>:<data-view>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<cluster-names>:<data-view>
<remote_cluster_name>:<target>

gchaps added a commit that referenced this pull request Nov 29, 2021
…119894)

* [DOCS] Changes index pattern to data views in intro docs

* [DOCS] Updates image of data views UI

* [DOCS] Removes faulty sentence

* [DOCS] removes sentence about index patterns

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
)

* [DOCS] Changes index pattern to data views in intro docs

* [DOCS] Updates image of data views UI

* [DOCS] Removes faulty sentence

* [DOCS] removes sentence about index patterns

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants