-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] implements new design for outputs UI #118910
[Fleet] implements new design for outputs UI #118910
Conversation
3e54ba0
to
fc8a40b
Compare
Pinging @elastic/fleet (Team:Fleet) |
fc8a40b
to
4ea6c6b
Compare
<EuiFlyoutFooter> | ||
<EuiFlexGroup justifyContent="spaceBetween"> | ||
<EuiFlexItem grow={false}> | ||
<EuiButtonEmpty onClick={() => onClose()} flush="left"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: using arrow function here is less optimal
...ublic/applications/fleet/sections/settings/components/edit_output_flyout/use_output_form.tsx
Outdated
Show resolved
Hide resolved
...ublic/applications/fleet/sections/settings/components/edit_output_flyout/use_output_form.tsx
Outdated
Show resolved
Hide resolved
)} | ||
</EuiFlexGroup> | ||
), | ||
width: '288px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could there be any eui theme
values for these hardcoded values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we have eui values here that will work for this table, I am still going to double check
...ublic/applications/fleet/sections/settings/components/edit_output_flyout/use_output_form.tsx
Outdated
Show resolved
Hide resolved
this might be an existing issue, on Storybook Preview I'm seeing an error: |
d53b616
to
97b5718
Compare
@juliaElastic Thanks for your review, I found the issue with the storybook story and it should be fixed. |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests, LGTM 🚀
💔 Backport failed
To backport manually run: |
# Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/legacy_settings_form/confirm_modal.tsx
While performing exploratory testing on this PR, found one issue and reported it as separate bug. |
For these two tags this mean that output is used as the default output to send integration data and monitoring data (We plan in the future to allow users to have different output to send integration data and monitoring data and this default column will make a lot more sense there) |
Hi Nicolas, Thanks for your feedback. As you mentioned that Output list section will have more number of outputs in future which further will send integration and monitoring data and Default column would tell what kind of data is being send for the respective output. Further questions:
Please provide your feedback. Thanks |
We have converted above proposed test cases into detailed ones and added them under Test Rail. Below is the reference link: |
Description
Related to #117317
Implement the new UI for multiple outputs, as we do not support multiple output type for now and this do not add a lot of user value to be able to only create multiple output on the same cluster, we choose to not allow to create new output for now but still go ahead with that new UI.
UI changes
Outputs List
Editing a preconfigured ouput (you cannot save or edit)
Editing the default output