Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] implements new design for outputs UI #118910

Merged
merged 9 commits into from
Nov 24, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 17, 2021

Description

Related to #117317

Implement the new UI for multiple outputs, as we do not support multiple output type for now and this do not add a lot of user value to be able to only create multiple output on the same cluster, we choose to not allow to create new output for now but still go ahead with that new UI.

UI changes

Outputs List

Screen Shot 2021-11-22 at 10 56 08 AM

Editing a preconfigured ouput (you cannot save or edit)

Screen Shot 2021-11-22 at 10 56 38 AM

Editing the default output
Screen Shot 2021-11-22 at 10 56 18 AM
Screen Shot 2021-11-22 at 10 56 23 AM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 17, 2021
@nchaulet nchaulet self-assigned this Nov 17, 2021
@nchaulet nchaulet force-pushed the feature-fleet-multiple-output-ui branch 5 times, most recently from 3e54ba0 to fc8a40b Compare November 22, 2021 15:34
@nchaulet nchaulet marked this pull request as ready for review November 22, 2021 16:01
@nchaulet nchaulet requested a review from a team as a code owner November 22, 2021 16:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet changed the title [Fleet] Add multiple outputs UI [Fleet] implements new design for outputs UI Nov 22, 2021
@nchaulet nchaulet force-pushed the feature-fleet-multiple-output-ui branch from fc8a40b to 4ea6c6b Compare November 22, 2021 16:15
<EuiFlyoutFooter>
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<EuiButtonEmpty onClick={() => onClose()} flush="left">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using arrow function here is less optimal

)}
</EuiFlexGroup>
),
width: '288px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could there be any eui theme values for these hardcoded values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we have eui values here that will work for this table, I am still going to double check

@juliaElastic
Copy link
Contributor

this might be an existing issue, on Storybook Preview I'm seeing an error:
image

@nchaulet nchaulet force-pushed the feature-fleet-multiple-output-ui branch from d53b616 to 97b5718 Compare November 23, 2021 16:57
@nchaulet
Copy link
Member Author

@juliaElastic Thanks for your review, I found the issue with the storybook story and it should be fixed.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 536 544 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1130 1138 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 636.0KB 644.2KB +8.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 105.3KB 106.6KB +1.3KB
Unknown metric groups

API count

id before after diff
fleet 1232 1240 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet requested a review from a team November 23, 2021 19:52
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests, LGTM 🚀

@nchaulet nchaulet merged commit 09dcf2d into elastic:main Nov 24, 2021
@nchaulet nchaulet deleted the feature-fleet-multiple-output-ui branch November 24, 2021 13:42
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 118910

nchaulet added a commit to nchaulet/kibana that referenced this pull request Nov 24, 2021
# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/legacy_settings_form/confirm_modal.tsx
nchaulet added a commit that referenced this pull request Nov 24, 2021
# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/settings/components/legacy_settings_form/confirm_modal.tsx
@nchaulet nchaulet mentioned this pull request Nov 25, 2021
3 tasks
@ghost
Copy link

ghost commented Dec 16, 2021

We have created below proposed test scenarios for this PR:

  • Scenario 01: Validate that ‘Fleet server hosts’ and ‘Outputs’ sections are displayed on Fleet> Settings tab.
  • Scenario 02: Validate that the correct URL is displayed under the ‘Host URL’ tab.
  • Scenario 03: Validate that user is redirected to ‘Fleet and Elastic Agent’ guide on clicking ‘Fleet User Guide’ link displayed under ‘Fleet server hosts’ section
  • Scenario 04: Validate that Fleet Server Host flyout is displayed on clicking ‘Edit hosts’ link.
  • Scenario 05: Validate that the user is able to update/add a new server host from Fleet Server Host flyout.
  • Scenario 06: Validate that ‘Default’ and ‘Elastic Cloud internal output’ outputs are displayed under ‘Outputs’ section on Fleet> Settings tab.
  • Scenario 07: Validate user is not able to edit/update pre-configured output under Settings tab.
  • Scenario 08: Validate user is able to edit/update default output and changes should be visible throughout under all policies.
  • Scenario 09: Validate that updated data is reflected in the output list after updating default output.
  • Scenario 10: Validate Save and deploy confirmation on editing/updating default output.
  • Scenario 11: Validate that default output settings are not saved on clicking Cancel from Edit Output dialog.
  • Scenario 12: Validate that error is displayed on saving output settings without host or with invalid host.

Please let us know if we are missing something and after validating these scenarios and behavior is confirmed, we will add them to the Testrail.

Further, we have one query for this new output list UI. We noticed that two tags i.e. Agent Integration and Agent monitoring are displayed under 'Default' column on Output list.
image

Can you please let me know significance of these two tags.

@ghost
Copy link

ghost commented Dec 17, 2021

While performing exploratory testing on this PR, found one issue and reported it as separate bug.

#121515

@nchaulet
Copy link
Member Author

Can you please let me know significance of these two tags.

For these two tags this mean that output is used as the default output to send integration data and monitoring data (We plan in the future to allow users to have different output to send integration data and monitoring data and this default column will make a lot more sense there)

@ghost
Copy link

ghost commented Dec 20, 2021

Can you please let me know significance of these two tags.

For these two tags this mean that output is used as the default output to send integration data and monitoring data (We plan in the future to allow users to have different output to send integration data and monitoring data and this default column will make a lot more sense there)

Hi Nicolas,

Thanks for your feedback.

As you mentioned that Output list section will have more number of outputs in future which further will send integration and monitoring data and Default column would tell what kind of data is being send for the respective output.

Further questions:

  1. Could you please confirm if this entry/tags will remain common for x no of agents we deploy on Kibana. And would contain only these two tags i.e Agent Integration and Agent Monitoring.
  2. Column header name 'Default' is not so user friendly and seems to be incomplete name. Can we have more appropriate label that is self explanatory.

Please provide your feedback.

Thanks

@ghost
Copy link

ghost commented Dec 24, 2021

We have converted above proposed test cases into detailed ones and added them under Test Rail.

Below is the reference link:
https://elastic.testrail.io/index.php?/suites/view/27&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=34818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants