Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Improvements and fixes for the import timeline test for the upgrade path #118849

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

MadameSheema
Copy link
Member

Summary

In this PR we are adding the following improvements and fixes to the Import timeline test for the upgrade path:

  • We are updating the timestamp values in order to accommodate some changes on the data.
  • We are updating the regular expression in order to make them less flaky and more reliable
  • We are adding new locators in order to make the tests more reliable and less flaky

Note: The changes on the locator should not affect the regular integration tests. Nevertheless, we'll see with the PR execution if something fails.

@MadameSheema MadameSheema added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Nov 17, 2021
@MadameSheema MadameSheema self-assigned this Nov 17, 2021
@MadameSheema MadameSheema requested review from a team as code owners November 17, 2021 10:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) November 17, 2021 10:58
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 0c4b58d into elastic:main Nov 17, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @MadameSheema 🚀

kibanamachine added a commit that referenced this pull request Nov 17, 2021
kibanamachine added a commit that referenced this pull request Nov 17, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
@MadameSheema MadameSheema deleted the upgrade/fixes-improvements branch May 16, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants