Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes index pattern from Discover docs #118811

Merged
merged 19 commits into from
Nov 19, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 16, 2021

Summary

This PR removes index patterns from the Discover docs and other minor changes.

Preview:
Advanced Settings
Search for relevance
Discover
View documents
Save search
Search sessions

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps
Copy link
Contributor Author

gchaps commented Nov 18, 2021

@elasticmachine merge upstream

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a handful of attribute, terminology, and image changes/recommendations, but nothing is critical. LGTM!

docs/discover/save-search.asciidoc Outdated Show resolved Hide resolved
docs/discover/save-search.asciidoc Outdated Show resolved Hide resolved
docs/discover/save-search.asciidoc Outdated Show resolved Hide resolved
docs/discover/search-for-relevance.asciidoc Outdated Show resolved Hide resolved
docs/discover/search-for-relevance.asciidoc Outdated Show resolved Hide resolved
docs/discover/search-sessions.asciidoc Outdated Show resolved Hide resolved
displays the current state of the search session. A clock indicates the search session is in progress.
Your search session begins automatically.
The icon after the dashboard title displays the current state of the search session.
A clock icon indicates the search session is in progress.
A checkmark indicates that the search session is complete.

. To instruct {kib} to continue a search in the background, click the clock icon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: Add the clock icon image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's shown in the image in the next step.

docs/discover/search-sessions.asciidoc Outdated Show resolved Hide resolved
@@ -320,7 +320,9 @@ Highlights results in *Discover* and saved searches on dashboards. Highlighting
slows requests when working on big documents.

[[doctable-legacy]]`doc_table:legacy`::
Controls the way the document table looks and works. Set this property to `true` to revert to the legacy implementation.
Controls the way the document table looks and works.
To use the new Document Explorer instead of the classic view, turn off this option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Document Explorer be bold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

docs/user/discover.asciidoc Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gchaps gchaps merged commit bd89451 into elastic:main Nov 19, 2021
@gchaps gchaps deleted the docs/discover-update-8.0 branch November 19, 2021 17:05
gchaps added a commit to gchaps/kibana that referenced this pull request Nov 19, 2021
* [DOCS] Removes index pattern from Discover docs

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/view-document.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Adds bold to Document Explorer

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
gchaps added a commit that referenced this pull request Nov 19, 2021
* [DOCS] Removes index pattern from Discover docs

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/view-document.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Adds bold to Document Explorer

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
* [DOCS] Removes index pattern from Discover docs

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/view-document.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Adds bold to Document Explorer

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* [DOCS] Removes index pattern from Discover docs

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/save-search.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/search-for-relevance.asciidoc

* Update docs/discover/view-document.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/user/discover.asciidoc

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/discover/search-sessions.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Adds bold to Document Explorer

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants