Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] remove internal params when querying registry #118693

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Nov 16, 2021

Summary

Fixes #117853

Removed the internal params when querying the package registry

To test:

  • open kibana integrations page, verify that integrations are loading successfully from registry without internal query param

@juliaElastic juliaElastic requested a review from a team as a code owner November 16, 2021 13:10
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor Author

@jsoriano please check if this looks good to you

@juliaElastic juliaElastic added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0 labels Nov 16, 2021
@nchaulet nchaulet changed the title [Fleet] removed internal param [Fleet] removed internal when querying registry Nov 16, 2021
@nchaulet nchaulet changed the title [Fleet] removed internal when querying registry [Fleet] remove internal params when querying registry Nov 16, 2021
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small test to fix but otherwise 🚀

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const url = new URL(
`${registryUrl}/search?package=${packageName}&internal=true&experimental=true`
);
const url = new URL(`${registryUrl}/search?package=${packageName}&experimental=true`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 1b0c062 into elastic:main Nov 17, 2021
@juliaElastic juliaElastic deleted the internal branch November 17, 2021 10:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 17, 2021
* removed internal param

* fixed tests

* fixed tests
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 17, 2021
)

* removed internal param

* fixed tests

* fixed tests

Co-authored-by: Julia Bardi <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
* removed internal param

* fixed tests

* fixed tests
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* removed internal param

* fixed tests

* fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Stop using the internal flag in queries to EPR
6 participants