-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] remove internal params when querying registry #118693
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@jsoriano please check if this looks good to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small test to fix but otherwise 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
const url = new URL( | ||
`${registryUrl}/search?package=${packageName}&internal=true&experimental=true` | ||
); | ||
const url = new URL(`${registryUrl}/search?package=${packageName}&experimental=true`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* removed internal param * fixed tests * fixed tests
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
) * removed internal param * fixed tests * fixed tests Co-authored-by: Julia Bardi <[email protected]>
* removed internal param * fixed tests * fixed tests
* removed internal param * fixed tests * fixed tests
Summary
Fixes #117853
Removed the
internal
params when querying the package registryTo test:
internal
query param